* [PATCH] I2C: SiByte: Correct a comment about frequency
@ 2008-05-11 2:10 Maciej W. Rozycki
2008-05-11 9:05 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2008-05-11 2:10 UTC (permalink / raw)
To: Jean Delvare, Andrew Morton; +Cc: i2c, linux-kernel
The frequency may have been once hardcoded to 100kHz, but currently it is
passed as an argument to i2c_sibyte_add_bus(), so update the comment to
match code. While at it, reformat a nearby comment for consistency. No
functional changes.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
It should be obvious. Please apply.
Maciej
patch-2.6.26-rc1-20080505-sibyte-i2c-add-bus-16
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
--- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:14:30.000000000 +0000
@@ -136,10 +136,10 @@ int __init i2c_sibyte_add_bus(struct i2c
{
struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
- /* register new adapter to i2c module... */
+ /* Register new adapter to i2c module... */
i2c_adap->algo = &i2c_sibyte_algo;
- /* Set the frequency to 100 kHz */
+ /* Set the requested frequency. */
csr_out32(speed, SMB_CSR(adap,R_SMB_FREQ));
csr_out32(0, SMB_CSR(adap,R_SMB_CONTROL));
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] I2C: SiByte: Correct a comment about frequency
2008-05-11 2:10 [PATCH] I2C: SiByte: Correct a comment about frequency Maciej W. Rozycki
@ 2008-05-11 9:05 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2008-05-11 9:05 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Andrew Morton, i2c, linux-kernel
On Sun, 11 May 2008 03:10:29 +0100 (BST), Maciej W. Rozycki wrote:
> The frequency may have been once hardcoded to 100kHz, but currently it is
> passed as an argument to i2c_sibyte_add_bus(), so update the comment to
> match code. While at it, reformat a nearby comment for consistency. No
> functional changes.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> It should be obvious. Please apply.
>
> Maciej
>
> patch-2.6.26-rc1-20080505-sibyte-i2c-add-bus-16
> diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
> --- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:14:30.000000000 +0000
> @@ -136,10 +136,10 @@ int __init i2c_sibyte_add_bus(struct i2c
> {
> struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
>
> - /* register new adapter to i2c module... */
> + /* Register new adapter to i2c module... */
> i2c_adap->algo = &i2c_sibyte_algo;
>
> - /* Set the frequency to 100 kHz */
> + /* Set the requested frequency. */
> csr_out32(speed, SMB_CSR(adap,R_SMB_FREQ));
> csr_out32(0, SMB_CSR(adap,R_SMB_CONTROL));
>
Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-11 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 2:10 [PATCH] I2C: SiByte: Correct a comment about frequency Maciej W. Rozycki
2008-05-11 9:05 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox