tip build broken on sparc64...

tip build broken on sparc64...

[David Miller]

It's this pteval_t stuff, probably breaks just about every
other platforms as well.

Please fix this, because I'd like to work on some ftrace
optimizations on sparc64, and do some testing of ftrace
in general.

mm/mmap.c: In function 'vm_get_page_prot_preserve':
mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function)
mm/mmap.c:86: error: (Each undeclared identifier is reported only once
mm/mmap.c:86: error: for each function it appears in.)
mm/mmap.c:86: error: expected ';' before 'newprotval'
mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

Re: tip build broken on sparc64...

[Ingo Molnar]

* David Miller <davem@davemloft.net> wrote:

> It's this pteval_t stuff, probably breaks just about every
> other platforms as well.
> 
> Please fix this, because I'd like to work on some ftrace
> optimizations on sparc64, and do some testing of ftrace
> in general.
> 
> mm/mmap.c: In function 'vm_get_page_prot_preserve':
> mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function)
> mm/mmap.c:86: error: (Each undeclared identifier is reported only once
> mm/mmap.c:86: error: for each function it appears in.)
> mm/mmap.c:86: error: expected ';' before 'newprotval'
> mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)

ok, will take care of it now.

	Ingo

Re: tip build broken on sparc64...

[Thomas Gleixner]

On Mon, 19 May 2008, Ingo Molnar wrote:
> * David Miller <davem@davemloft.net> wrote:
> 
> > It's this pteval_t stuff, probably breaks just about every
> > other platforms as well.
> > 
> > Please fix this, because I'd like to work on some ftrace
> > optimizations on sparc64, and do some testing of ftrace
> > in general.
> > 
> > mm/mmap.c: In function 'vm_get_page_prot_preserve':
> > mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function)
> > mm/mmap.c:86: error: (Each undeclared identifier is reported only once
> > mm/mmap.c:86: error: for each function it appears in.)
> > mm/mmap.c:86: error: expected ';' before 'newprotval'
> > mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)
> 
> ok, will take care of it now.

That was a conflict of mprotect patches, which is resolved. Just
checked that current -tip builds a sparc64 defconfig.

Thanks,	

	tglx

Re: tip build broken on sparc64...

[David Miller]

From: Thomas Gleixner <tglx@linutronix.de>
Date: Mon, 19 May 2008 18:15:43 +0200 (CEST)

> On Mon, 19 May 2008, Ingo Molnar wrote:
> > * David Miller <davem@davemloft.net> wrote:
> > 
> > > It's this pteval_t stuff, probably breaks just about every
> > > other platforms as well.
> > > 
> > > Please fix this, because I'd like to work on some ftrace
> > > optimizations on sparc64, and do some testing of ftrace
> > > in general.
> > > 
> > > mm/mmap.c: In function 'vm_get_page_prot_preserve':
> > > mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function)
> > > mm/mmap.c:86: error: (Each undeclared identifier is reported only once
> > > mm/mmap.c:86: error: for each function it appears in.)
> > > mm/mmap.c:86: error: expected ';' before 'newprotval'
> > > mm/mmap.c:88: error: 'newprotval' undeclared (first use in this function)
> > 
> > ok, will take care of it now.
> 
> That was a conflict of mprotect patches, which is resolved. Just
> checked that current -tip builds a sparc64 defconfig.

Thanks a lot.