From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: HAVE_CLK (for <linux/clk.h> support)
Date: Tue, 27 May 2008 16:14:55 -0700 [thread overview]
Message-ID: <200805271614.55233.david-b@pacbell.net> (raw)
In-Reply-To: <1211879340-22013-1-git-send-email-felipe.balbi@nokia.com>
On Tuesday 27 May 2008, Felipe Balbi wrote:
> This patch adds support for MUSB and TUSB controllers
> integrated into omap2430 and davinci. It also adds support
> for external tusb6010 controller.
The most significant issue I know of with this patch [0] is actually
an arch issue. On ones like x86, with no support for the clock API,
this driver will build but not link:
ERROR: "clk_enable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_disable" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_put" [drivers/usb/musb/musb_hdrc.ko] undefined!
ERROR: "clk_get" [drivers/usb/musb/musb_hdrc.ko] undefined!
I don't know of any other drivers with this particular issue,
but nonetheless ... I think the following is an appropriate
resolution.
Comments from anyone else?
- Dave
[0] Posted this AM on linux-usb but evidently too big for any
of the archives I know about ... 450 KB, which includes
host, gadget, and OTG functionality. Previous versions
are archived, in the one-file-added-per-patch style.
--- g26.orig/drivers/usb/musb/Kconfig 2008-05-27 16:02:41.000000000 -0700
+++ g26/drivers/usb/musb/Kconfig 2008-05-27 16:01:09.000000000 -0700
@@ -8,7 +8,7 @@ comment "Enable Host or Gadget support t
# (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
config USB_MUSB_HDRC
- depends on USB || USB_GADGET
+ depends on HAVE_CLK && (USB || USB_GADGET)
select TWL4030_USB if MACH_OMAP_3430SDP
tristate 'Inventra Highspeed Dual Role Controller (TI, ...)'
help
--- g26.orig/arch/Kconfig 2008-05-27 16:00:14.000000000 -0700
+++ g26/arch/Kconfig 2008-05-27 16:00:41.000000000 -0700
@@ -39,3 +39,6 @@ config HAVE_KRETPROBES
config HAVE_DMA_ATTRS
def_bool n
+
+config HAVE_CLK
+ def_bool n
--- g26.orig/arch/arm/Kconfig 2008-05-27 16:01:15.000000000 -0700
+++ g26/arch/arm/Kconfig 2008-05-27 16:02:33.000000000 -0700
@@ -458,12 +458,14 @@ config ARCH_DAVINCI
select GENERIC_TIME
select GENERIC_CLOCKEVENTS
select GENERIC_GPIO
+ select HAVE_CLK
help
Support for TI's DaVinci platform.
config ARCH_OMAP
bool "TI OMAP"
select GENERIC_GPIO
+ select HAVE_CLK
select HAVE_GPIO_LIB
select GENERIC_TIME
select GENERIC_CLOCKEVENTS
next parent reply other threads:[~2008-05-27 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200805231044.59969.david-b@pacbell.net>
[not found] ` <1211879340-22013-1-git-send-email-felipe.balbi@nokia.com>
2008-05-27 23:14 ` David Brownell [this message]
2008-05-28 0:01 ` HAVE_CLK (for <linux/clk.h> support) Felipe Balbi
2008-05-28 1:41 ` David Brownell
2008-09-01 9:48 ` Bryan Wu
2008-09-01 10:00 ` Felipe Balbi
2008-09-01 10:05 ` Bryan Wu
2008-09-01 10:12 ` Felipe Balbi
2008-05-28 0:05 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805271614.55233.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox