The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Bryan Wu <cooloney@kernel.org>, Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: blackfin drivers/net/smc91x.c build error
Date: Fri, 6 Jun 2008 19:22:12 +0300	[thread overview]
Message-ID: <20080606162212.GC2201@cs181133002.pp.htv.fi> (raw)

drivers/net/smc91x.c fails as follows on blackfin:

<--  snip  -->

...
  CC      drivers/net/smc91x.o
...
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
...
make[3]: *** [drivers/net/smc91x.o] Error 1

<--  snip  -->

The required action seems to be a revert of:
commit 099c736a470c8080a166e7a089f1e48e15f9947c
(Revert "smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade") (sic).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2008-06-06 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 16:22 Adrian Bunk [this message]
2008-06-06 19:52 ` blackfin drivers/net/smc91x.c build error Mike Frysinger
2008-06-10 13:53   ` Adrian Bunk
2008-06-10 17:13     ` Mike Frysinger
2008-06-10 17:34       ` Adrian Bunk
2008-06-11  3:37         ` Bryan Wu
2008-06-11  3:43           ` Bryan Wu
2008-06-11  3:47           ` Linus Torvalds
2008-06-11  3:55             ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080606162212.GC2201@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=cooloney@kernel.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox