From: Adrian Bunk <bunk@kernel.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Bryan Wu <cooloney@kernel.org>, Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: blackfin drivers/net/smc91x.c build error
Date: Tue, 10 Jun 2008 20:34:50 +0300 [thread overview]
Message-ID: <20080610173450.GC11685@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <8bd0f97a0806101013w42b9028j5dfa38d654f3d05f@mail.gmail.com>
On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
> >> > drivers/net/smc91x.c fails as follows on blackfin:
> >> > ...
> >> > CC drivers/net/smc91x.o
> >> > ...
> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
> >> > ...
> >>
> >> it's a known issue (been known for quite a long time actually). Bryan
> >> has brought this up in the past already.
> >
> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
> > correct or how else should it be resolved?
>
> Bryan is taking care of it ... it may just stay broken in favor of
> waiting for the merge from the net tree.
>
> > This issue is the only remaining problem preventing that all blackfin
> > defconfigs will compile in 2.6.26...
>
> not really true.
>...
What other build errors do you get in Linus' tree?
> -mike
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-06-10 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 16:22 blackfin drivers/net/smc91x.c build error Adrian Bunk
2008-06-06 19:52 ` Mike Frysinger
2008-06-10 13:53 ` Adrian Bunk
2008-06-10 17:13 ` Mike Frysinger
2008-06-10 17:34 ` Adrian Bunk [this message]
2008-06-11 3:37 ` Bryan Wu
2008-06-11 3:43 ` Bryan Wu
2008-06-11 3:47 ` Linus Torvalds
2008-06-11 3:55 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610173450.GC11685@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=cooloney@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox