From: Nikanth Karthikesan <knikanth@suse.de>
To: linux-aio@kvack.org
Cc: linux-kernel@vger.kernel.org, Benjamin LaHaise <bcrl@kvack.org>,
Jeff Moyer <jmoyer@redhat.com>,
Zach Brown <zach.brown@oracle.com>
Subject: [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself
Date: Thu, 26 Jun 2008 09:27:27 +0530 [thread overview]
Message-ID: <200806260927.27995.knikanth@suse.de> (raw)
Avoid using queue_delayed_work in aio_kick_handler() to run itself
immediately. Instead use aio_run_all_iocbs()
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/fs/aio.c b/fs/aio.c
index e27f611..7817e8f 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -823,21 +823,13 @@ static void aio_kick_handler(struct work_struct *work)
struct kioctx *ctx = container_of(work, struct kioctx, wq.work);
mm_segment_t oldfs = get_fs();
struct mm_struct *mm;
- int requeue;
set_fs(USER_DS);
- use_mm(ctx->mm);
- spin_lock_irq(&ctx->ctx_lock);
- requeue =__aio_run_iocbs(ctx);
mm = ctx->mm;
- spin_unlock_irq(&ctx->ctx_lock);
+ use_mm(mm);
+ aio_run_all_iocbs(ctx);
unuse_mm(mm);
set_fs(oldfs);
- /*
- * we're in a worker thread already, don't use queue_delayed_work,
- */
- if (requeue)
- queue_delayed_work(aio_wq, &ctx->wq, 0);
}
next reply other threads:[~2008-06-26 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 3:57 Nikanth Karthikesan [this message]
2008-06-27 13:11 ` [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself Jeff Moyer
2008-06-30 5:50 ` Nikanth Karthikesan
2008-07-01 8:51 ` Nikanth Karthikesan
2008-07-07 13:44 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806260927.27995.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=bcrl@kvack.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox