From: Nikanth Karthikesan <knikanth@suse.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-aio@kvack.org, linux-kernel@vger.kernel.org,
Benjamin LaHaise <bcrl@kvack.org>,
Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself
Date: Mon, 30 Jun 2008 11:20:27 +0530 [thread overview]
Message-ID: <200806301120.27743.knikanth@suse.de> (raw)
In-Reply-To: <x49prq3t43a.fsf@segfault.boston.devel.redhat.com>
On Friday 27 June 2008 18:41:37 Jeff Moyer wrote:
> Nikanth Karthikesan <knikanth@suse.de> writes:
> > Avoid using queue_delayed_work in aio_kick_handler() to run itself
> > immediately. Instead use aio_run_all_iocbs()
>
> Can you give some rationale for this change? Also, how did you test it?
>
The comment in aio_kick_handler(), "we're in a worker thread already, don't
use queue_delayed_work" triggered me to do this. Ran multiple instances
of Stephen Hemminger's aio cp for basic testing.
I think this would make it unfair between different kioctx? May be only the
comment should be removed?
Thanks
Nikanth Karthikesan
next prev parent reply other threads:[~2008-06-30 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 3:57 [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself Nikanth Karthikesan
2008-06-27 13:11 ` Jeff Moyer
2008-06-30 5:50 ` Nikanth Karthikesan [this message]
2008-07-01 8:51 ` Nikanth Karthikesan
2008-07-07 13:44 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806301120.27743.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=bcrl@kvack.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox