* [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
@ 2008-06-30 18:35 Randy Dunlap
2008-06-30 18:42 ` Jesse Barnes
0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2008-06-30 18:35 UTC (permalink / raw)
To: linux-pci, lkml; +Cc: mb, jbarnes, jejb, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
so add one like other similar stubs. Otherwise there can be build errors,
as here:
linux-next-20080630/drivers/ssb/main.c:1175: error: implicit declaration of function 'pci_set_consistent_dma_mask'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/linux/pci.h | 5 +++++
1 file changed, 5 insertions(+)
--- linux-next-20080630.orig/include/linux/pci.h
+++ linux-next-20080630/include/linux/pci.h
@@ -854,6 +854,11 @@ static inline int pci_set_dma_mask(struc
return -EIO;
}
+static inline int pci_set_consistent_dma_mask(struct pci_dev *dev, u64 mask)
+{
+ return -EIO;
+}
+
static inline int pci_set_dma_max_seg_size(struct pci_dev *dev,
unsigned int size)
{
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 18:35 [PATCH] PCI: add stub for pci_set_consistent_dma_mask() Randy Dunlap
@ 2008-06-30 18:42 ` Jesse Barnes
2008-06-30 20:40 ` Michael Buesch
0 siblings, 1 reply; 7+ messages in thread
From: Jesse Barnes @ 2008-06-30 18:42 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-pci, lkml, mb, jejb, akpm
On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> so add one like other similar stubs. Otherwise there can be build errors,
> as here:
>
> linux-next-20080630/drivers/ssb/main.c:1175: error: implicit declaration of
> function 'pci_set_consistent_dma_mask'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied to linux-next, thanks Randy.
Jesse
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 18:42 ` Jesse Barnes
@ 2008-06-30 20:40 ` Michael Buesch
2008-06-30 21:00 ` Jesse Barnes
0 siblings, 1 reply; 7+ messages in thread
From: Michael Buesch @ 2008-06-30 20:40 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Randy Dunlap, linux-pci, lkml, jejb, akpm
On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > so add one like other similar stubs. Otherwise there can be build errors,
> > as here:
> >
> > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit declaration of
> > function 'pci_set_consistent_dma_mask'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Applied to linux-next, thanks Randy.
I guess this is probably also needed for 2.6.26.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 20:40 ` Michael Buesch
@ 2008-06-30 21:00 ` Jesse Barnes
2008-06-30 21:10 ` Michael Buesch
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jesse Barnes @ 2008-06-30 21:00 UTC (permalink / raw)
To: Michael Buesch; +Cc: Randy Dunlap, linux-pci, lkml, jejb, akpm
On Monday, June 30, 2008 1:40 pm Michael Buesch wrote:
> On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> > On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > > so add one like other similar stubs. Otherwise there can be build
> > > errors, as here:
> > >
> > > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit
> > > declaration of function 'pci_set_consistent_dma_mask'
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Applied to linux-next, thanks Randy.
>
> I guess this is probably also needed for 2.6.26.
Hm, current upstream seems to have pci_set_consistent_dma_mask under
CONFIG_SSB_PCIHOST, which in turn depends on PCI = y (or PCI = SSB, what does
that mean?).
But yeah, it wouldn't hurt to push this for 2.6.26 too.
Jesse
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 21:00 ` Jesse Barnes
@ 2008-06-30 21:10 ` Michael Buesch
2008-06-30 21:12 ` Michael Buesch
2008-07-02 4:31 ` Grant Grundler
2 siblings, 0 replies; 7+ messages in thread
From: Michael Buesch @ 2008-06-30 21:10 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Randy Dunlap, linux-pci, lkml, jejb, akpm
On Monday 30 June 2008 23:00:02 Jesse Barnes wrote:
> On Monday, June 30, 2008 1:40 pm Michael Buesch wrote:
> > On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> > > On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > >
> > > > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > > > so add one like other similar stubs. Otherwise there can be build
> > > > errors, as here:
> > > >
> > > > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit
> > > > declaration of function 'pci_set_consistent_dma_mask'
> > > >
> > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Applied to linux-next, thanks Randy.
> >
> > I guess this is probably also needed for 2.6.26.
>
> Hm, current upstream seems to have pci_set_consistent_dma_mask under
> CONFIG_SSB_PCIHOST, which in turn depends on PCI = y (or PCI = SSB, what does
> that mean?).
>
> But yeah, it wouldn't hurt to push this for 2.6.26 too.
Yeah, I wasn't talking about ssb, but rather other drivers.
Maybe there's no such user of that function, however.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 21:00 ` Jesse Barnes
2008-06-30 21:10 ` Michael Buesch
@ 2008-06-30 21:12 ` Michael Buesch
2008-07-02 4:31 ` Grant Grundler
2 siblings, 0 replies; 7+ messages in thread
From: Michael Buesch @ 2008-06-30 21:12 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Randy Dunlap, linux-pci, lkml, jejb, akpm
On Monday 30 June 2008 23:00:02 Jesse Barnes wrote:
> On Monday, June 30, 2008 1:40 pm Michael Buesch wrote:
> > On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> > > On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > >
> > > > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > > > so add one like other similar stubs. Otherwise there can be build
> > > > errors, as here:
> > > >
> > > > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit
> > > > declaration of function 'pci_set_consistent_dma_mask'
> > > >
> > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > Applied to linux-next, thanks Randy.
> >
> > I guess this is probably also needed for 2.6.26.
>
> Hm, current upstream seems to have pci_set_consistent_dma_mask under
> CONFIG_SSB_PCIHOST,
Yeah, I wasn't talking about ssb, but rather other drivers.
Maybe there's no such user of that function, however.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()
2008-06-30 21:00 ` Jesse Barnes
2008-06-30 21:10 ` Michael Buesch
2008-06-30 21:12 ` Michael Buesch
@ 2008-07-02 4:31 ` Grant Grundler
2 siblings, 0 replies; 7+ messages in thread
From: Grant Grundler @ 2008-07-02 4:31 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Michael Buesch, Randy Dunlap, linux-pci, lkml, jejb, akpm
On Mon, Jun 30, 2008 at 02:00:02PM -0700, Jesse Barnes wrote:
> > > Applied to linux-next, thanks Randy.
> >
> > I guess this is probably also needed for 2.6.26.
>
> Hm, current upstream seems to have pci_set_consistent_dma_mask under
> CONFIG_SSB_PCIHOST, which in turn depends on PCI = y (or PCI = SSB, what does
> that mean?).
>
> But yeah, it wouldn't hurt to push this for 2.6.26 too.
While I don't expect problems, it's not a critical fix. And there
are very few drivers that support both PCI and !PCI bus flavors.
I personally would not apply this patch to any "stable" kernel.
grant
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-07-02 4:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-30 18:35 [PATCH] PCI: add stub for pci_set_consistent_dma_mask() Randy Dunlap
2008-06-30 18:42 ` Jesse Barnes
2008-06-30 20:40 ` Michael Buesch
2008-06-30 21:00 ` Jesse Barnes
2008-06-30 21:10 ` Michael Buesch
2008-06-30 21:12 ` Michael Buesch
2008-07-02 4:31 ` Grant Grundler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox