From: David Brownell <david-b@pacbell.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c
Date: Fri, 4 Jul 2008 09:50:17 -0700 [thread overview]
Message-ID: <200807040950.17877.david-b@pacbell.net> (raw)
In-Reply-To: <s5hk5g1ls9l.wl%tiwai@suse.de>
On Friday 04 July 2008, Takashi Iwai wrote:
>
> > The proper fix probably is to make PPC_MPC5200_GPIO also select
> > GENERIC_GPIO.
I think it's higher in the dependency tree than that.
> > I don't think that building GPIO_LIB w/o GENERIC_GPIO
> > should be supported.
>
> [Added David to Cc]
>
> Then HAVE_GPIO_LIB should depend on GENERIC_GPIO.
They must go together ... right. Anything using gpiolib
without the interface it implements needs a head-exam. ;)
But since ISTR that Kconfig (still) doesn't get dependencies
right when you "select" something that depends on something
else, that particular solution won't fly.
> Or, linux/gpio.h should be fixed so that the code can be built
> properly without GENERIC_GPIO.
No; GENERIC_GPIO is the interface, HAVE_GPIO_LIB is one
of the valid ways to implement it.
It should work if HAVE_GPIO_LIB selected GENERIC_GPIO...
- Dave
prev parent reply other threads:[~2008-07-04 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 11:20 [PATCH] fix build error of driver/mfd/tc6393xb.c Takashi Iwai
2008-07-04 11:47 ` Dmitry Baryshkov
2008-07-04 12:04 ` Takashi Iwai
2008-07-04 12:42 ` Dmitry Baryshkov
2008-07-04 12:59 ` Takashi Iwai
2008-07-04 13:22 ` Dmitry Baryshkov
2008-07-04 13:59 ` Takashi Iwai
2008-07-04 14:22 ` Dmitry Baryshkov
2008-07-04 15:24 ` Takashi Iwai
2008-07-04 15:27 ` Dmitry Baryshkov
2008-07-04 16:47 ` Takashi Iwai
2008-07-04 16:54 ` David Brownell
2008-07-05 8:31 ` Dmitry Baryshkov
2008-07-05 17:13 ` David Brownell
2008-07-07 16:09 ` Takashi Iwai
2008-07-07 16:19 ` David Brownell
2008-07-07 16:23 ` Takashi Iwai
2008-07-04 16:52 ` David Brownell
2008-07-04 16:50 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807040950.17877.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox