From: David Brownell <david-b@pacbell.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix build error of driver/mfd/tc6393xb.c
Date: Mon, 7 Jul 2008 09:19:05 -0700 [thread overview]
Message-ID: <200807070919.05305.david-b@pacbell.net> (raw)
In-Reply-To: <s5hr6a5vfpv.wl%tiwai@suse.de>
On Monday 07 July 2008, Takashi Iwai wrote:
>
> > The most natural fix is to have the Kconfig for PPC_MPC52xx
> > select both GENERIC_GPIO and HAVE_GPIO_LIB.
>
> Yes. I, however, still feel uneasy by the fact that the combination
> GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work. We should either fix
> it to work or disallow the combination.
As in, HAVE_GPIO_LIB depends on GENERIC_GPIO? Fine with me;
but I'm not sure that would work. Won't Kconfig gleefully let
the "select" succeed but not select what it depends on?
We already "disallow" that combination ... but we lack any
automated way to enforce that.
next prev parent reply other threads:[~2008-07-07 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 11:20 [PATCH] fix build error of driver/mfd/tc6393xb.c Takashi Iwai
2008-07-04 11:47 ` Dmitry Baryshkov
2008-07-04 12:04 ` Takashi Iwai
2008-07-04 12:42 ` Dmitry Baryshkov
2008-07-04 12:59 ` Takashi Iwai
2008-07-04 13:22 ` Dmitry Baryshkov
2008-07-04 13:59 ` Takashi Iwai
2008-07-04 14:22 ` Dmitry Baryshkov
2008-07-04 15:24 ` Takashi Iwai
2008-07-04 15:27 ` Dmitry Baryshkov
2008-07-04 16:47 ` Takashi Iwai
2008-07-04 16:54 ` David Brownell
2008-07-05 8:31 ` Dmitry Baryshkov
2008-07-05 17:13 ` David Brownell
2008-07-07 16:09 ` Takashi Iwai
2008-07-07 16:19 ` David Brownell [this message]
2008-07-07 16:23 ` Takashi Iwai
2008-07-04 16:52 ` David Brownell
2008-07-04 16:50 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807070919.05305.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox