From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Adrian Bunk <bunk@kernel.org>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>
Date: Sat, 26 Jul 2008 12:50:25 -0700 [thread overview]
Message-ID: <20080726125025.465d524b.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0807261852050.582@blonde.site>
On Sat, 26 Jul 2008 19:13:43 +0100 (BST) Hugh Dickins <hugh@veritas.com> wrote:
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/tlb.h: In function 'tlb_remove_page':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'
tlb_finish_mmu() inlines tlb_flush_mmu() and ends up being quite large.
tlb_finish_mmu() has five callsites in core kernel.
The above error is God's way of telling us that it's all too large to
be inlined.
uninlining these things would be a bit of a pita because of the various
arch overrides. But it really is the right thing to do.
next prev parent reply other threads:[~2008-07-26 19:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 17:18 [PATCH] include/asm-generic/tlb.h must include <linux/pagemap.h> Haavard Skinnemoen
2008-07-26 17:38 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Adrian Bunk
2008-07-26 17:59 ` Johannes Weiner
2008-07-26 18:07 ` Adrian Bunk
2008-07-26 18:13 ` Hugh Dickins
2008-07-26 19:50 ` Andrew Morton [this message]
2008-07-26 20:15 ` Hugh Dickins
2008-07-26 20:26 ` Andrew Morton
2008-07-26 20:37 ` Hugh Dickins
2008-07-26 20:42 ` Adrian Bunk
2008-07-26 21:05 ` Hugh Dickins
2008-07-27 13:04 ` Adrian Bunk
2008-07-27 13:40 ` Hugh Dickins
2008-07-27 13:43 ` [PATCH] exec: include pagemap.h again to fix build Hugh Dickins
2008-07-26 18:30 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726125025.465d524b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox