From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>
Date: Sat, 26 Jul 2008 20:30:34 +0200 [thread overview]
Message-ID: <20080726203034.456e7678@siona.local> (raw)
In-Reply-To: <20080726173832.GE9301@cs181140183.pp.htv.fi>
On Sat, 26 Jul 2008 20:38:32 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> The patch is not the correct fix since the actual problem comes from
> free_pages_and_swap_cache() in swap.h
True, but I saw this comment in swap.h:
/* only sparc can not include linux/pagemap.h in this file
* so leave page_cache_release and release_pages undeclared... */
so I thought it might be safer to add the include to tlb.h instead.
Haavard
prev parent reply other threads:[~2008-07-26 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 17:18 [PATCH] include/asm-generic/tlb.h must include <linux/pagemap.h> Haavard Skinnemoen
2008-07-26 17:38 ` [2.6 patch] linux/swap.h must #include <linux/pagemap.h> Adrian Bunk
2008-07-26 17:59 ` Johannes Weiner
2008-07-26 18:07 ` Adrian Bunk
2008-07-26 18:13 ` Hugh Dickins
2008-07-26 19:50 ` Andrew Morton
2008-07-26 20:15 ` Hugh Dickins
2008-07-26 20:26 ` Andrew Morton
2008-07-26 20:37 ` Hugh Dickins
2008-07-26 20:42 ` Adrian Bunk
2008-07-26 21:05 ` Hugh Dickins
2008-07-27 13:04 ` Adrian Bunk
2008-07-27 13:40 ` Hugh Dickins
2008-07-27 13:43 ` [PATCH] exec: include pagemap.h again to fix build Hugh Dickins
2008-07-26 18:30 ` Haavard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726203034.456e7678@siona.local \
--to=haavard.skinnemoen@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox