From: Simon Horman <horms@verge.net.au>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
Matthew Wilcox <matthew@wil.cx>,
Sven Wegener <sven.wegener@stealer.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus()
Date: Fri, 8 Aug 2008 08:59:50 +1000 [thread overview]
Message-ID: <20080807225950.GA6094@verge.net.au> (raw)
In-Reply-To: <200808070950.51400.jbarnes@virtuousgeek.org>
On Thu, Aug 07, 2008 at 09:50:50AM -0700, Jesse Barnes wrote:
> On Wednesday, August 6, 2008 9:56 pm Simon Horman wrote:
> > Check the return value of device_create_bin_file in pci_create_bus and
> > unwind if necessary. Don't propagate error to caller, as failure to create
> > these files shouldn't prevent PCI from being initialised. Instead, just
> > log a warning.
> >
> > Cc: Sven Wegener <sven.wegener@stealer.net>
> > Cc: Michael Ellerman <michael@ellerman.id.au>
> > Cc: Matthew Wilcox <matthew@wil.cx>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
>
> Applied, thanks for your persistence, Simon! :)
Thanks, sorry for not getting it right much earlier.
next prev parent reply other threads:[~2008-08-07 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 10:16 [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus() Simon Horman
2008-08-05 10:33 ` Michael Ellerman
2008-08-05 10:39 ` Sven Wegener
2008-08-05 11:00 ` Simon Horman
2008-08-05 11:14 ` Simon Horman
2008-08-05 11:28 ` Matthew Wilcox
2008-08-05 12:15 ` Simon Horman
2008-08-05 12:26 ` Matthew Wilcox
2008-08-06 0:57 ` Simon Horman
2008-08-06 13:19 ` Matthew Wilcox
2008-08-06 23:25 ` Simon Horman
2008-08-06 23:30 ` Simon Horman
2008-08-07 0:30 ` Michael Ellerman
2008-08-07 1:06 ` Simon Horman
2008-08-07 4:56 ` Simon Horman
2008-08-07 16:50 ` Jesse Barnes
2008-08-07 22:59 ` Simon Horman [this message]
2008-08-05 13:21 ` Sven Wegener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807225950.GA6094@verge.net.au \
--to=horms@verge.net.au \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michael@ellerman.id.au \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox