[PATCH] ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

[PATCH] ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

[Bartlomiej Zolnierkiewicz]

Since we solved this by overriding default ->{in,out}put_data
methods in {q40,falcon}ide M68K_IDE_SWAP define can go away.

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 include/asm-m68k/ide.h |    9 ---------
 1 file changed, 9 deletions(-)

Index: b/include/asm-m68k/ide.h
===================================================================
--- a/include/asm-m68k/ide.h
+++ b/include/asm-m68k/ide.h
@@ -92,15 +92,6 @@
 #define outsw_swapw(port, addr, n)	raw_outsw_swapw((u16 *)port, addr, n)
 #endif
 
-
-/* Q40 and Atari have byteswapped IDE busses and since many interesting
- * values in the identification string are text, chars and words they
- * happened to be almost correct without swapping.. However *_capacity
- * is needed for drives over 8 GB. RZ */
-#if defined(CONFIG_Q40) || defined(CONFIG_ATARI)
-#define M68K_IDE_SWAPW  (MACH_IS_Q40 || MACH_IS_ATARI)
-#endif
-
 #ifdef CONFIG_BLK_DEV_FALCON_IDE
 #define IDE_ARCH_LOCK
 

Re: [PATCH] ide: remove M68K_IDE_SWAPW define from <asm-m68k/ide.h>

[Geert Uytterhoeven]

On Sun, 10 Aug 2008, Bartlomiej Zolnierkiewicz wrote:
> Since we solved this by overriding default ->{in,out}put_data
> methods in {q40,falcon}ide M68K_IDE_SWAP define can go away.
> 
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> ---
>  include/asm-m68k/ide.h |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> Index: b/include/asm-m68k/ide.h
> ===================================================================
> --- a/include/asm-m68k/ide.h
> +++ b/include/asm-m68k/ide.h
> @@ -92,15 +92,6 @@
>  #define outsw_swapw(port, addr, n)	raw_outsw_swapw((u16 *)port, addr, n)
>  #endif
>  
> -
> -/* Q40 and Atari have byteswapped IDE busses and since many interesting
> - * values in the identification string are text, chars and words they
> - * happened to be almost correct without swapping.. However *_capacity
> - * is needed for drives over 8 GB. RZ */
> -#if defined(CONFIG_Q40) || defined(CONFIG_ATARI)
> -#define M68K_IDE_SWAPW  (MACH_IS_Q40 || MACH_IS_ATARI)
> -#endif
> -
>  #ifdef CONFIG_BLK_DEV_FALCON_IDE
>  #define IDE_ARCH_LOCK

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds