From: Ingo Molnar <mingo@elte.hu>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: markus.t.metzger@gmail.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Roland McGrath <roland@redhat.com>
Subject: Re: [patch] x86, ptrace: void dopiness
Date: Mon, 22 Sep 2008 13:50:58 +0200 [thread overview]
Message-ID: <20080922115058.GB14301@elte.hu> (raw)
In-Reply-To: <20080919145250.A6000@sedona.ch.intel.com>
* Markus Metzger <markus.t.metzger@intel.com> wrote:
> +++ gits.x86/arch/x86/kernel/ptrace.c 2008-09-19 13:53:02.%N +0200
> @@ -738,7 +738,7 @@
> unsigned int sig = 0;
>
> /* we ignore the error in case we were not tracing child */
> - (void)ds_release_bts(child);
> + ds_release_bts(child);
hm, here the cast is OK because we actually ignore the return value.
> @@ -947,7 +947,7 @@
> clear_tsk_thread_flag(child, TIF_SYSCALL_EMU);
> #endif
> #ifdef CONFIG_X86_PTRACE_BTS
> - (void)ds_release_bts(child);
> + ds_release_bts(child);
is it right/intentional here?
Ingo
next prev parent reply other threads:[~2008-09-22 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:52 [patch] x86, ptrace: void dopiness Markus Metzger
2008-09-19 13:17 ` linux-os (Dick Johnson)
2008-09-22 11:50 ` Ingo Molnar [this message]
2008-09-22 12:00 ` Metzger, Markus T
2008-09-22 12:07 ` Ingo Molnar
2008-09-23 11:30 ` Metzger, Markus T
2008-09-23 11:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922115058.GB14301@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox