From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: markus.t.metzger@gmail.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Roland McGrath <roland@redhat.com>,
"linux-os (Dick Johnson)" <linux-os@analogic.com>
Subject: Re: [patch] x86, ptrace: void dopiness
Date: Tue, 23 Sep 2008 13:48:32 +0200 [thread overview]
Message-ID: <20080923114832.GF14840@elte.hu> (raw)
In-Reply-To: <029E5BE7F699594398CA44E3DDF55444027827AD@swsmsx413.ger.corp.intel.com>
* Metzger, Markus T <markus.t.metzger@intel.com> wrote:
> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@elte.hu]
> >Sent: Montag, 22. September 2008 14:08
> >To: Metzger, Markus T
>
> >> The void-cast is intentional in both cases.
> >>
> >> I thought it a question of style, i.e. that we don't want void casts
> >> just like we want NULL instead of 0.
> >
> >ok.
> >
> >But you could mark ds_release_bts() as a __must_check
> >function, in that
> >case the (void) has functional aspects as well: the kernel build will
> >complain if a return value is ignored unintentionally.
>
> Wouldn't every non-void function be __must_check?
no, only those which we mark so explicitly.
Ingo
prev parent reply other threads:[~2008-09-23 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 12:52 [patch] x86, ptrace: void dopiness Markus Metzger
2008-09-19 13:17 ` linux-os (Dick Johnson)
2008-09-22 11:50 ` Ingo Molnar
2008-09-22 12:00 ` Metzger, Markus T
2008-09-22 12:07 ` Ingo Molnar
2008-09-23 11:30 ` Metzger, Markus T
2008-09-23 11:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923114832.GF14840@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox