[PATCH] Only register notifiers when the braille console is used.

[PATCH] Only register notifiers when the braille console is used.

[Samuel Thibault]

Only register the braille driver VT and keyboard notifiers when the
braille console is used.  Avoids eating insert or backspace keys.

http://bugzilla.kernel.org/show_bug.cgi?id=11242

Signed-off-by: Pascal Terjan <pterjan@mandriva.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 drivers/accessibility/braille/braille_console.c |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
index 0a5f6b2..d672cfe 100644
--- a/drivers/accessibility/braille/braille_console.c
+++ b/drivers/accessibility/braille/braille_console.c
@@ -376,6 +376,8 @@ int braille_register_console(struct console *console, int index,
 	console->flags |= CON_ENABLED;
 	console->index = index;
 	braille_co = console;
+	register_keyboard_notifier(&keyboard_notifier_block);
+	register_vt_notifier(&vt_notifier_block);
 	return 0;
 }
 
@@ -383,15 +385,8 @@ int braille_unregister_console(struct console *console)
 {
 	if (braille_co != console)
 		return -EINVAL;
+	unregister_keyboard_notifier(&keyboard_notifier_block);
+	unregister_vt_notifier(&vt_notifier_block);
 	braille_co = NULL;
 	return 0;
 }
-
-static int __init braille_init(void)
-{
-	register_keyboard_notifier(&keyboard_notifier_block);
-	register_vt_notifier(&vt_notifier_block);
-	return 0;
-}
-
-console_initcall(braille_init);
-- 
1.6.0.2

Re: [stable] [PATCH] Only register notifiers when the braille console is used.

[Greg KH]

On Mon, Sep 22, 2008 at 11:40:31PM +0200, Samuel Thibault wrote:
> Only register the braille driver VT and keyboard notifiers when the
> braille console is used.  Avoids eating insert or backspace keys.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=11242
> 
> Signed-off-by: Pascal Terjan <pterjan@mandriva.com>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

As this patch isn't upstream yet, if you want it to be included
automatically in the next -stable release when it is added to Linus's
tree, just add a:
  Cc: stable <stable@kernel.org>

to the signed-off-by: area.  When it goes into Linus's tree, we will
automatically get notified and it will then be added to the -stable tree
with no additional work for you.

hope this helps,

greg k-h

Re: [PATCH] Only register notifiers when the braille console is used.

[Andrew Morton]

On Mon, 22 Sep 2008 23:40:31 +0200
Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:

> Only register the braille driver VT and keyboard notifiers when the
> braille console is used.  Avoids eating insert or backspace keys.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=11242
> 
> Signed-off-by: Pascal Terjan <pterjan@mandriva.com>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

I have a suspision from your signoff trail that Pascal actually authored
this patch.  Is that correct?

If so, the authorship should have been tracked by putting his From:
line right at the top of the changelog.

Thanks.

Re: [PATCH] Only register notifiers when the braille console is used.

[Samuel Thibault]

Andrew Morton, le Mon 22 Sep 2008 16:36:21 -0700, a écrit :
> On Mon, 22 Sep 2008 23:40:31 +0200
> Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > Only register the braille driver VT and keyboard notifiers when the
> > braille console is used.  Avoids eating insert or backspace keys.
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=11242
> > 
> > Signed-off-by: Pascal Terjan <pterjan@mandriva.com>
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> I have a suspision from your signoff trail that Pascal actually authored
> this patch.  Is that correct?

Err, yes.

> If so, the authorship should have been tracked by putting his From:
> line right at the top of the changelog.

Ah, sorry, I still haven't catched up with the new usages.

Samuel