[PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Neil Horman]

Hey-
	The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly.  These
symbols are missing from the powerpc kernel.  This patch adds those symbols in
properly.  Tested successfully by myself and the reporter.

Regards
Neil

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>


 machine_kexec.c |   10 ++++++++++
 1 file changed, 10 insertions(+)


diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
index aab7688..2f9b5aa 100644
--- a/arch/powerpc/kernel/machine_kexec.c
+++ b/arch/powerpc/kernel/machine_kexec.c
@@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#else
+	VMCOREINFO_SYMBOL(contig_page_data);
+#endif
+}
+
 /*
  * Do not allocate memory (or fail in any way) in machine_kexec().
  * We are past the point of no return, committed to rebooting now.
-- 
/***************************************************
 *Neil Horman
 *nhorman@tuxdriver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Ken'ichi Ohmichi]

Hi Neil,

I had created similar patch, but your patch is better than mine because
your patch has right configuration dependency. So I think this patch is
fine.

Reviewed-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>


Thanks
Ken'ichi Ohmichi

* Reference:
http://lists.infradead.org/pipermail/kexec/2008-June/001970.html

Neil Horman wrote:
> Hey-
> 	The makdumpdile dump filtering program, in some modes of operation needs
> the node_data and/or contig_page_data symbols to function properly.  These
> symbols are missing from the powerpc kernel.  This patch adds those symbols in
> properly.  Tested successfully by myself and the reporter.
> 
> Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> 
>  machine_kexec.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> 
> diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> index aab7688..2f9b5aa 100644
> --- a/arch/powerpc/kernel/machine_kexec.c
> +++ b/arch/powerpc/kernel/machine_kexec.c
> @@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
>  		ppc_md.machine_kexec_cleanup(image);
>  }
>  
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_NEED_MULTIPLE_NODES
> +	VMCOREINFO_SYMBOL(node_data);
> +	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> +#else
> +	VMCOREINFO_SYMBOL(contig_page_data);
> +#endif
> +}
> +
>  /*
>   * Do not allocate memory (or fail in any way) in machine_kexec().
>   * We are past the point of no return, committed to rebooting now.

Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Vivek Goyal]

On Thu, Oct 09, 2008 at 11:20:27AM -0400, Neil Horman wrote:
> Hey-
> 	The makdumpdile dump filtering program, in some modes of operation needs
> the node_data and/or contig_page_data symbols to function properly.  These
> symbols are missing from the powerpc kernel.  This patch adds those symbols in
> properly.  Tested successfully by myself and the reporter.
> 
> Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> 
>  machine_kexec.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> 
> diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> index aab7688..2f9b5aa 100644
> --- a/arch/powerpc/kernel/machine_kexec.c
> +++ b/arch/powerpc/kernel/machine_kexec.c
> @@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
>  		ppc_md.machine_kexec_cleanup(image);
>  }
>  
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_NEED_MULTIPLE_NODES
> +	VMCOREINFO_SYMBOL(node_data);
> +	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> +#else
> +	VMCOREINFO_SYMBOL(contig_page_data);
> +#endif
> +}
> +

Hi Neil,

Looks like contig_page_data is already being saved in arch independent
portion of kexec (crash_save_vmcoreinfo_init()). We probably don't need
to save it here again?

#ifndef CONFIG_NEED_MULTIPLE_NODES
        VMCOREINFO_SYMBOL(mem_map);
        VMCOREINFO_SYMBOL(contig_page_data);
#endif

Thanks
Vivek

Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Neil Horman]

On Fri, Oct 17, 2008 at 05:08:54PM -0400, Vivek Goyal wrote:
> On Thu, Oct 09, 2008 at 11:20:27AM -0400, Neil Horman wrote:
> > Hey-
> > 	The makdumpdile dump filtering program, in some modes of operation needs
> > the node_data and/or contig_page_data symbols to function properly.  These
> > symbols are missing from the powerpc kernel.  This patch adds those symbols in
> > properly.  Tested successfully by myself and the reporter.
> > 
> > Regards
> > Neil
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > 
> > 
> >  machine_kexec.c |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > 
> > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> > index aab7688..2f9b5aa 100644
> > --- a/arch/powerpc/kernel/machine_kexec.c
> > +++ b/arch/powerpc/kernel/machine_kexec.c
> > @@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
> >  		ppc_md.machine_kexec_cleanup(image);
> >  }
> >  
> > +void arch_crash_save_vmcoreinfo(void)
> > +{
> > +#ifdef CONFIG_NEED_MULTIPLE_NODES
> > +	VMCOREINFO_SYMBOL(node_data);
> > +	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> > +#else
> > +	VMCOREINFO_SYMBOL(contig_page_data);
> > +#endif
> > +}
> > +
> 
> Hi Neil,
> 
> Looks like contig_page_data is already being saved in arch independent
> portion of kexec (crash_save_vmcoreinfo_init()). We probably don't need
> to save it here again?
> 
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>         VMCOREINFO_SYMBOL(mem_map);
>         VMCOREINFO_SYMBOL(contig_page_data);
> #endif
> 
> Thanks
> Vivek
> 
Oops your right.  I fixed that in RHEL and must not have searched for it
upstream.  I'll repost a corrected patch monday.
Thanks!
Neil

Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Neil Horman]

 Hey Vivek, as promised, a corrected patch
	
	The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly.  These
symbols are missing from the powerpc kernel.  This patch adds those symbols in
properly.  Tested successfully by myself and the reporter.

Regards
Neil

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>


 machine_kexec.c |    8 ++++++++
 1 file changed, 8 insertions(+)


diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
index aab7688..5d51e75 100644
--- a/arch/powerpc/kernel/machine_kexec.c
+++ b/arch/powerpc/kernel/machine_kexec.c
@@ -44,6 +44,14 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#endif
+}
+
 /*
  * Do not allocate memory (or fail in any way) in machine_kexec().
  * We are past the point of no return, committed to rebooting now.

Re: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

[Vivek Goyal]

On Sun, Oct 19, 2008 at 08:28:05PM -0400, Neil Horman wrote:
>  Hey Vivek, as promised, a corrected patch
> 	
> 	The makdumpdile dump filtering program, in some modes of operation needs
> the node_data and/or contig_page_data symbols to function properly.  These
> symbols are missing from the powerpc kernel.  This patch adds those symbols in
> properly.  Tested successfully by myself and the reporter.
> 
> Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> 
>  machine_kexec.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> 
> diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> index aab7688..5d51e75 100644
> --- a/arch/powerpc/kernel/machine_kexec.c
> +++ b/arch/powerpc/kernel/machine_kexec.c
> @@ -44,6 +44,14 @@ void machine_kexec_cleanup(struct kimage *image)
>  		ppc_md.machine_kexec_cleanup(image);
>  }
>  
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_NEED_MULTIPLE_NODES
> +	VMCOREINFO_SYMBOL(node_data);
> +	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
> +#endif
> +}
> +

Looks good to me.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek