From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: add an fsync tracer
Date: Thu, 6 Nov 2008 08:20:56 +0100 [thread overview]
Message-ID: <20081106072056.GL15731@elte.hu> (raw)
In-Reply-To: <20081105123604.633105ca@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > > + buffer = kmalloc(4096, GFP_KERNEL);
> > > + err = d_path(&file->f_path, buffer, 4096);
hm, magic constants.
> > > + if (IS_ERR(err))
> > > + goto out;
> > > +
> > > + ftrace_printk("Process %s is calling fsync on %s\n",
> > > + current->comm, err);
> >
> > err? not buffer?
>
> correct, not buffer
>
> it won't work if you use buffer.
please use some other name than 'err' - since "error" is just a
property of the path string pointer you get back from do_path().
Ingo
next prev parent reply other threads:[~2008-11-06 7:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 17:49 [PATCH] ftrace: add an fsync tracer Arjan van de Ven
2008-11-05 19:43 ` Marcin Slusarz
2008-11-05 20:36 ` Arjan van de Ven
2008-11-06 7:20 ` Ingo Molnar [this message]
2008-11-06 12:55 ` Peter Zijlstra
2008-11-06 13:28 ` Frédéric Weisbecker
2008-11-06 14:06 ` Arjan van de Ven
2008-11-06 14:19 ` Peter Zijlstra
2008-11-06 14:31 ` Arjan van de Ven
2008-11-06 14:50 ` Peter Zijlstra
2008-11-06 15:01 ` Arjan van de Ven
2008-11-06 15:34 ` Steven Rostedt
2008-11-06 17:45 ` Arjan van de Ven
2008-11-06 20:19 ` Frank Ch. Eigler
2008-11-06 20:29 ` Peter Zijlstra
2008-11-06 20:57 ` Frank Ch. Eigler
2008-11-06 21:18 ` Jason Baron
2008-11-06 21:53 ` Mathieu Desnoyers
2008-11-06 22:14 ` Frank Ch. Eigler
2008-11-06 22:25 ` Mathieu Desnoyers
2008-11-06 23:25 ` Frank Ch. Eigler
2008-11-07 4:25 ` Arjan van de Ven
2008-11-07 5:12 ` Mathieu Desnoyers
2008-11-06 21:13 ` Arjan van de Ven
2008-11-06 21:20 ` Frank Ch. Eigler
2008-11-06 14:14 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106072056.GL15731@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox