From: Andi Kleen <andi@firstfloor.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tracing/function-return-tracer: Make the function return tracer lockless
Date: Thu, 13 Nov 2008 18:34:51 +0100 [thread overview]
Message-ID: <20081113173451.GY3810@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0811131219250.23751@gandalf.stny.rr.com>
> So the answer to this is:
>
> i = index++;
> barrier();
> write to index i (not index);
That was my first thought when I wrote the original email,
but the disadvantage is that barrier() is a big hammer
that flushes everything and can make the code much worse.
That is why I suggested local_add_return() instead.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-13 17:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:47 [PATCH 1/2] tracing/function-return-tracer: Make the function return tracer lockless Frederic Weisbecker
2008-11-12 22:15 ` Ingo Molnar
2008-11-13 8:50 ` Frédéric Weisbecker
2008-11-13 8:55 ` Ingo Molnar
2008-11-13 9:16 ` Frédéric Weisbecker
2008-11-13 9:23 ` Ingo Molnar
2008-11-13 9:27 ` Frédéric Weisbecker
2008-11-13 9:40 ` Ingo Molnar
2008-11-13 12:36 ` Frédéric Weisbecker
2008-11-13 12:54 ` Ingo Molnar
2008-11-13 12:59 ` Peter Zijlstra
2008-11-13 13:02 ` Ingo Molnar
2008-11-13 17:26 ` Frédéric Weisbecker
2008-11-13 18:57 ` Ingo Molnar
2008-11-13 20:06 ` Frédéric Weisbecker
2008-11-13 14:53 ` Andi Kleen
2008-11-13 17:01 ` Frédéric Weisbecker
2008-11-13 17:12 ` Andi Kleen
2008-11-13 17:21 ` Steven Rostedt
2008-11-13 17:34 ` Andi Kleen [this message]
2008-11-13 17:32 ` Steven Rostedt
2008-11-13 17:46 ` Frédéric Weisbecker
2008-11-13 18:29 ` Andi Kleen
2008-11-13 18:35 ` Steven Rostedt
2008-11-13 18:55 ` Andi Kleen
2008-11-13 19:03 ` Steven Rostedt
2008-11-13 19:19 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113173451.GY3810@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox