* [PATCH 2/3] account_steal_time: kill the unneeded account_group_system_time()
@ 2008-11-17 14:39 Oleg Nesterov
2008-11-17 15:54 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2008-11-17 14:39 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar, Roland McGrath
Cc: Doug Chapman, Frank Mayhar, Peter Zijlstra, linux-kernel
I don't actually understand account_steal_time() and I failed to find the
commit which added account_group_system_time(), but this looks bogus.
In any case rq->idle must be single-threaded, so it can't have ->totals.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- K-28/kernel/sched.c~ACCT_STEAL_KILL_GACCT 2008-11-10 13:05:09.000000000 +0100
+++ K-28/kernel/sched.c 2008-11-16 23:40:05.000000000 +0100
@@ -4198,7 +4198,6 @@ void account_steal_time(struct task_stru
if (p == rq->idle) {
p->stime = cputime_add(p->stime, steal);
- account_group_system_time(p, steal);
if (atomic_read(&rq->nr_iowait) > 0)
cpustat->iowait = cputime64_add(cpustat->iowait, tmp);
else
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] account_steal_time: kill the unneeded account_group_system_time()
2008-11-17 14:39 [PATCH 2/3] account_steal_time: kill the unneeded account_group_system_time() Oleg Nesterov
@ 2008-11-17 15:54 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-17 15:54 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Roland McGrath, Doug Chapman, Frank Mayhar,
Peter Zijlstra, linux-kernel
* Oleg Nesterov <oleg@redhat.com> wrote:
> I don't actually understand account_steal_time() and I failed to find the
> commit which added account_group_system_time(), but this looks bogus.
> In any case rq->idle must be single-threaded, so it can't have ->totals.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> --- K-28/kernel/sched.c~ACCT_STEAL_KILL_GACCT 2008-11-10 13:05:09.000000000 +0100
> +++ K-28/kernel/sched.c 2008-11-16 23:40:05.000000000 +0100
> @@ -4198,7 +4198,6 @@ void account_steal_time(struct task_stru
>
> if (p == rq->idle) {
> p->stime = cputime_add(p->stime, steal);
> - account_group_system_time(p, steal);
> if (atomic_read(&rq->nr_iowait) > 0)
> cpustat->iowait = cputime64_add(cpustat->iowait, tmp);
could be a typo - is there no similar construct nearby?
Makes sense in any case, applied to tip/core/signal - thanks Oleg.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-17 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 14:39 [PATCH 2/3] account_steal_time: kill the unneeded account_group_system_time() Oleg Nesterov
2008-11-17 15:54 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox