* [PATCH] ipc: do not goto to the next line
@ 2008-11-17 15:10 Denis V. Lunev
2008-11-17 15:23 ` Américo Wang
0 siblings, 1 reply; 2+ messages in thread
From: Denis V. Lunev @ 2008-11-17 15:10 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Denis V. Lunev
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
ipc/sem.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/ipc/sem.c b/ipc/sem.c
index 0821224..b91d455 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
if (timeout && jiffies_left == 0)
error = -EAGAIN;
list_del(&queue.list);
- goto out_unlock_free;
out_unlock_free:
sem_unlock(sma);
--
1.5.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipc: do not goto to the next line
2008-11-17 15:10 [PATCH] ipc: do not goto to the next line Denis V. Lunev
@ 2008-11-17 15:23 ` Américo Wang
0 siblings, 0 replies; 2+ messages in thread
From: Américo Wang @ 2008-11-17 15:23 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: akpm, linux-kernel
On Mon, Nov 17, 2008 at 06:10:52PM +0300, Denis V. Lunev wrote:
>Signed-off-by: Denis V. Lunev <den@openvz.org>
>---
> ipc/sem.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/ipc/sem.c b/ipc/sem.c
>index 0821224..b91d455 100644
>--- a/ipc/sem.c
>+++ b/ipc/sem.c
>@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
> if (timeout && jiffies_left == 0)
> error = -EAGAIN;
> list_del(&queue.list);
>- goto out_unlock_free;
>
> out_unlock_free:
> sem_unlock(sma);
Aha, this goto is obviously useless. :)
If you need,
Reviewed-by: WANG Cong <wangcong@zeuux.org>
--
"Sometimes the only way to stay sane is to go a little crazy."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-17 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 15:10 [PATCH] ipc: do not goto to the next line Denis V. Lunev
2008-11-17 15:23 ` Américo Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox