* [PATCH] Do not free io context when taking recursive faults in do_exit
@ 2008-11-19 6:45 Nikanth Karthikesan
2008-11-19 9:16 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Nikanth Karthikesan @ 2008-11-19 6:45 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
When taking recursive faults in do_exit, if the io_context is not null,
exit_io_context() is being called. But it might decrement the refcount
more than once. It is better to leave this task alone.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/kernel/exit.c b/kernel/exit.c
index 80137a5..22dedf5 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1024,8 +1024,6 @@ NORET_TYPE void do_exit(long code)
* task into the wait for ever nirwana as well.
*/
tsk->flags |= PF_EXITPIDONE;
- if (tsk->io_context)
- exit_io_context();
set_current_state(TASK_UNINTERRUPTIBLE);
schedule();
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Do not free io context when taking recursive faults in do_exit
2008-11-19 6:45 [PATCH] Do not free io context when taking recursive faults in do_exit Nikanth Karthikesan
@ 2008-11-19 9:16 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-11-19 9:16 UTC (permalink / raw)
To: Nikanth Karthikesan; +Cc: linux-kernel
On Wed, Nov 19 2008, Nikanth Karthikesan wrote:
> When taking recursive faults in do_exit, if the io_context is not null,
> exit_io_context() is being called. But it might decrement the refcount
> more than once. It is better to leave this task alone.
Agree, it's better to just leave that alone. Applied to for-2.6.29.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-19 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-19 6:45 [PATCH] Do not free io context when taking recursive faults in do_exit Nikanth Karthikesan
2008-11-19 9:16 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox