* [PATCH] [GENDISK] fix disk_part_tbl always alloced in node 0: set node_id before refered in alloc_disk
@ 2008-11-19 16:09 crquan
2008-11-20 7:35 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: crquan @ 2008-11-19 16:09 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
From: Cheng Renquan <crquan@gmail.com>
disk->node_id will be refered in allocating in disk_expand_part_tbl, so we
should set it before disk->node_id is refered.
Signed-off-by: Cheng Renquan <crquan@gmail.com>
---
block/genhd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 27549e4..2f7feda 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1102,6 +1102,7 @@ struct gendisk *alloc_disk_node(int minors, int node_id)
kfree(disk);
return NULL;
}
+ disk->node_id = node_id;
if (disk_expand_part_tbl(disk, 0)) {
free_part_stats(&disk->part0);
kfree(disk);
@@ -1116,7 +1117,6 @@ struct gendisk *alloc_disk_node(int minors, int node_id)
device_initialize(disk_to_dev(disk));
INIT_WORK(&disk->async_notify,
media_change_notify_thread);
- disk->node_id = node_id;
}
return disk;
}
--
1.6.0.4.758.g36c05
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [GENDISK] fix disk_part_tbl always alloced in node 0: set node_id before refered in alloc_disk
2008-11-19 16:09 [PATCH] [GENDISK] fix disk_part_tbl always alloced in node 0: set node_id before refered in alloc_disk crquan
@ 2008-11-20 7:35 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-11-20 7:35 UTC (permalink / raw)
To: crquan; +Cc: linux-kernel
On Thu, Nov 20 2008, crquan@gmail.com wrote:
> From: Cheng Renquan <crquan@gmail.com>
>
> disk->node_id will be refered in allocating in disk_expand_part_tbl, so we
> should set it before disk->node_id is refered.
>
> Signed-off-by: Cheng Renquan <crquan@gmail.com>
> ---
> block/genhd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 27549e4..2f7feda 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1102,6 +1102,7 @@ struct gendisk *alloc_disk_node(int minors, int node_id)
> kfree(disk);
> return NULL;
> }
> + disk->node_id = node_id;
> if (disk_expand_part_tbl(disk, 0)) {
> free_part_stats(&disk->part0);
> kfree(disk);
> @@ -1116,7 +1117,6 @@ struct gendisk *alloc_disk_node(int minors, int node_id)
> device_initialize(disk_to_dev(disk));
> INIT_WORK(&disk->async_notify,
> media_change_notify_thread);
> - disk->node_id = node_id;
> }
> return disk;
> }
Good spotting, applied!
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-20 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-19 16:09 [PATCH] [GENDISK] fix disk_part_tbl always alloced in node 0: set node_id before refered in alloc_disk crquan
2008-11-20 7:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox