From: Rusty Russell <rusty@rustcorp.com.au>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
npiggin@suse.de, axboe@kernel.dk
Subject: Re: [PATCH 1/1] cpumask: smp_call_function_many()
Date: Thu, 20 Nov 2008 10:08:31 +1030 [thread overview]
Message-ID: <200811201008.31978.rusty@rustcorp.com.au> (raw)
In-Reply-To: <492475BF.6090502@ct.jp.nec.com>
On Thursday 20 November 2008 06:53:27 Hiroshi Shimamoto wrote:
> Rusty Russell wrote:
> > + /* Fastpath: do that cpu by itself. */
> > + if (next_cpu >= nr_cpu_ids)
> > + smp_call_function_single(cpu, func, info, wait);
>
> Hi Rusty,
>
> I think, return is needed here. If not func will be called twice.
Indeed, thanks!
Fixed,
Rusty.
next prev parent reply other threads:[~2008-11-19 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 14:45 [PATCH 1/1] cpumask: smp_call_function_many() Rusty Russell
2008-11-19 20:23 ` Hiroshi Shimamoto
2008-11-19 23:38 ` Rusty Russell [this message]
2008-11-20 3:21 ` Nick Piggin
2008-11-20 4:44 ` Rusty Russell
2008-11-20 6:57 ` Nick Piggin
2008-11-20 11:08 ` Rusty Russell
2008-11-20 11:12 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811201008.31978.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=axboe@kernel.dk \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox