From: Ingo Molnar <mingo@elte.hu>
To: eranian@googlemail.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
x86@kernel.org, andi@firstfloor.org, eranian@gmail.com,
sfr@canb.auug.org.au
Subject: Re: [patch 20/24] perfmon: system calls interface
Date: Wed, 26 Nov 2008 15:02:20 +0100 [thread overview]
Message-ID: <20081126140220.GD6562@elte.hu> (raw)
In-Reply-To: <492d0c0b.170e660a.15ba.ffffdabf@mx.google.com>
* eranian@googlemail.com <eranian@googlemail.com> wrote:
> +
> +/*
> + * unlike the other perfmon system calls, this one returns a file descriptor
> + * or a value < 0 in case of error, very much like open() or socket()
> + */
> +asmlinkage long sys_pfm_create(int flags, struct pfarg_sinfo __user *ureq)
> +{
> + struct pfm_context *new_ctx;
> + struct pfarg_sinfo sif;
> + int ret;
> +
> + PFM_DBG("flags=0x%x sif=%p", flags, ureq);
> +
> + if (perfmon_disabled)
> + return -ENOSYS;
> +
> + if (flags) {
> + PFM_DBG("no flags accepted yet");
> + return -EINVAL;
the canonical return code for non-yet-supported flags is not -EINVAL
but -ENOSYS.
Ingo
next prev parent reply other threads:[~2008-11-26 14:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 8:42 [patch 20/24] perfmon: system calls interface eranian
2008-11-26 12:02 ` Andi Kleen
2008-11-26 13:43 ` Ingo Molnar
2008-11-26 14:00 ` Ingo Molnar
2008-11-26 16:59 ` Oleg Nesterov
2008-11-27 12:25 ` stephane eranian
2008-11-27 12:41 ` Andi Kleen
2008-11-27 14:22 ` stephane eranian
2008-11-27 14:42 ` Ingo Molnar
2008-11-27 15:16 ` stephane eranian
2008-12-01 0:49 ` Paul Mackerras
2008-12-01 6:05 ` stephane eranian
2008-12-03 2:02 ` Roland McGrath
2008-12-04 1:05 ` Roland McGrath
2008-11-26 14:02 ` Ingo Molnar [this message]
2008-11-26 14:08 ` Ingo Molnar
2008-11-27 14:28 ` stephane eranian
2008-11-26 14:11 ` Ingo Molnar
2008-11-26 14:13 ` Ingo Molnar
2008-11-27 14:01 ` Thomas Gleixner
2008-11-27 14:07 ` stephane eranian
2008-12-01 6:10 ` stephane eranian
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 21:36 eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126140220.GD6562@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=eranian@gmail.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox