From: Andi Kleen <andi@firstfloor.org>
To: eranian@gmail.com
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
x86@kernel.org, andi@firstfloor.org, sfr@canb.auug.org.au,
Roland McGrath <roland@redhat.com>
Subject: Re: [patch 20/24] perfmon: system calls interface
Date: Thu, 27 Nov 2008 13:41:16 +0100 [thread overview]
Message-ID: <20081127124116.GK6703@one.firstfloor.org> (raw)
In-Reply-To: <7c86c4470811270425i435a2adcq565d674070fd44db@mail.gmail.com>
> int pfm_create(int flags, pfarg_sinfo_t *sif, char *fmt_name, void
> *fmt_arg, size_t arg_sz);
>
> The kernel would look at the last 3 arguments ONLY if it saw the
> PFM_FL_SMPL_FMT bit
> set in flags. We follow the model used by open(2).
Normally it's a better model to enforce 0 (or whatever appropiate)
in unused argument. That can be done by checking and returning EINVAL.
>
> I want to double-check that you are fine with this approach.
My recommendation would be to go with the full format
from the beginning, because otherwise there is a versioning problem
with glibc.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-27 12:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 8:42 [patch 20/24] perfmon: system calls interface eranian
2008-11-26 12:02 ` Andi Kleen
2008-11-26 13:43 ` Ingo Molnar
2008-11-26 14:00 ` Ingo Molnar
2008-11-26 16:59 ` Oleg Nesterov
2008-11-27 12:25 ` stephane eranian
2008-11-27 12:41 ` Andi Kleen [this message]
2008-11-27 14:22 ` stephane eranian
2008-11-27 14:42 ` Ingo Molnar
2008-11-27 15:16 ` stephane eranian
2008-12-01 0:49 ` Paul Mackerras
2008-12-01 6:05 ` stephane eranian
2008-12-03 2:02 ` Roland McGrath
2008-12-04 1:05 ` Roland McGrath
2008-11-26 14:02 ` Ingo Molnar
2008-11-26 14:08 ` Ingo Molnar
2008-11-27 14:28 ` stephane eranian
2008-11-26 14:11 ` Ingo Molnar
2008-11-26 14:13 ` Ingo Molnar
2008-11-27 14:01 ` Thomas Gleixner
2008-11-27 14:07 ` stephane eranian
2008-12-01 6:10 ` stephane eranian
-- strict thread matches above, loose matches on Subject: below --
2008-11-25 21:36 eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081127124116.GK6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox