* [PATCH] x86: uv bau interrupt -- use proper interrupt number
@ 2008-11-26 21:02 Cyrill Gorcunov
2008-11-26 21:18 ` Cliff Wickman
0 siblings, 1 reply; 3+ messages in thread
From: Cyrill Gorcunov @ 2008-11-26 21:02 UTC (permalink / raw)
To: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Andi Kleen; +Cc: LKML
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
CC: Andi Kleen <andi@firstfloor.org>
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/arch/x86/kernel/entry_64.S
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
+++ linux-2.6.git/arch/x86/kernel/entry_64.S
@@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
#endif
-apicinterrupt 220 \
+apicinterrupt UV_BAU_MESSAGE \
uv_bau_message_intr1 uv_bau_message_interrupt
apicinterrupt LOCAL_TIMER_VECTOR \
apic_timer_interrupt smp_apic_timer_interrupt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: uv bau interrupt -- use proper interrupt number
2008-11-26 21:02 [PATCH] x86: uv bau interrupt -- use proper interrupt number Cyrill Gorcunov
@ 2008-11-26 21:18 ` Cliff Wickman
2008-11-28 13:17 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Cliff Wickman @ 2008-11-26 21:18 UTC (permalink / raw)
To: Cyrill Gorcunov
Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner, Andi Kleen, LKML
On Thu, Nov 27, 2008 at 12:02:10AM +0300, Cyrill Gorcunov wrote:
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> CC: Andi Kleen <andi@firstfloor.org>
> ---
> arch/x86/kernel/entry_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.git/arch/x86/kernel/entry_64.S
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
> +++ linux-2.6.git/arch/x86/kernel/entry_64.S
> @@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
> irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
> #endif
>
> -apicinterrupt 220 \
> +apicinterrupt UV_BAU_MESSAGE \
> uv_bau_message_intr1 uv_bau_message_interrupt
> apicinterrupt LOCAL_TIMER_VECTOR \
> apic_timer_interrupt smp_apic_timer_interrupt
> --
The interrupt handler does not use the hardcoded 220, but
the declaration should indeed be fixed as above.
(such a fix was once submitted
http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't
go anywhere)
Thanks for the follow-up.
-Cliff
--
Cliff Wickman
Silicon Graphics, Inc.
cpw@sgi.com
(651) 683-3824
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: uv bau interrupt -- use proper interrupt number
2008-11-26 21:18 ` Cliff Wickman
@ 2008-11-28 13:17 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-11-28 13:17 UTC (permalink / raw)
To: Cliff Wickman
Cc: Cyrill Gorcunov, H. Peter Anvin, Thomas Gleixner, Andi Kleen,
LKML
* Cliff Wickman <cpw@sgi.com> wrote:
> On Thu, Nov 27, 2008 at 12:02:10AM +0300, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > CC: Andi Kleen <andi@firstfloor.org>
> > ---
> > arch/x86/kernel/entry_64.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-2.6.git/arch/x86/kernel/entry_64.S
> > ===================================================================
> > --- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
> > +++ linux-2.6.git/arch/x86/kernel/entry_64.S
> > @@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
> > irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
> > #endif
> >
> > -apicinterrupt 220 \
> > +apicinterrupt UV_BAU_MESSAGE \
> > uv_bau_message_intr1 uv_bau_message_interrupt
> > apicinterrupt LOCAL_TIMER_VECTOR \
> > apic_timer_interrupt smp_apic_timer_interrupt
> > --
>
> The interrupt handler does not use the hardcoded 220, but
> the declaration should indeed be fixed as above.
> (such a fix was once submitted
> http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't
> go anywhere)
> Thanks for the follow-up.
applied to tip/x86/irq, thanks guys!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-28 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-26 21:02 [PATCH] x86: uv bau interrupt -- use proper interrupt number Cyrill Gorcunov
2008-11-26 21:18 ` Cliff Wickman
2008-11-28 13:17 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox