Re: mmotm 2008-11-29-01-53 uploaded

Re: mmotm 2008-11-29-01-53 uploaded

[KAMEZAWA Hiroyuki]

On Sat, 29 Nov 2008 01:59:56 -0800
akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> It contains the following patches against 2.6.28-rc6:
> 
Hi, in recent changes of linux-next.patch

==
static void __init param_sysfs_builtin(void)
{
        struct kernel_param *kp;
        unsigned int name_len;
        char modname[MODULE_NAME_LEN];

        for (kp = __start___param; kp < __stop___param; kp++) {
                char *dot;

                if (kp->perm == 0)
                        continue;

                dot = strchr(kp->name, '.');
                BUG_ON(!dot); <======================================(*)
                name_len = dot - kp->name + 1;
                strlcpy(modname, kp->name, name_len);
                kernel_add_sysfs_param(modname, kp, name_len);
        }

==
Above (*) is added.

I hit BUG_ON() at (*). That was because usbcore was not a module and module param
kp->name was "nousb".... not including any dot.
(If compled as module, the kernel works well.)

I'm sorry if already fixed.

Thanks,
-Kame

Re: mmotm 2008-11-29-01-53 uploaded

[Andrew Morton]

On Mon, 1 Dec 2008 11:10:40 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

> On Sat, 29 Nov 2008 01:59:56 -0800
> akpm@linux-foundation.org wrote:
> 
> > The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > It contains the following patches against 2.6.28-rc6:
> > 
> Hi, in recent changes of linux-next.patch
> 
> ==
> static void __init param_sysfs_builtin(void)
> {
>         struct kernel_param *kp;
>         unsigned int name_len;
>         char modname[MODULE_NAME_LEN];
> 
>         for (kp = __start___param; kp < __stop___param; kp++) {
>                 char *dot;
> 
>                 if (kp->perm == 0)
>                         continue;
> 
>                 dot = strchr(kp->name, '.');
>                 BUG_ON(!dot); <======================================(*)
>                 name_len = dot - kp->name + 1;
>                 strlcpy(modname, kp->name, name_len);
>                 kernel_add_sysfs_param(modname, kp, name_len);
>         }
> 
> ==
> Above (*) is added.
> 
> I hit BUG_ON() at (*). That was because usbcore was not a module and module param
> kp->name was "nousb".... not including any dot.
> (If compled as module, the kernel works well.)
> 

Thanks, that'll be

commit 9b473de87209fa86eb421b23386693b461612f30
Author: Rusty Russell <rusty@rustcorp.com.au>
Date:   Wed Oct 22 10:00:22 2008 -0500

    param: Fix duplicate module prefixes

I assume.  Rusty's been on the schnapps again ;)

Re: mmotm 2008-11-29-01-53 uploaded

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi Andrew,

On Sun, 30 Nov 2008 19:11:24 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> Thanks, that'll be
> 
> commit 9b473de87209fa86eb421b23386693b461612f30
> Author: Rusty Russell <rusty@rustcorp.com.au>
> Date:   Wed Oct 22 10:00:22 2008 -0500
> 
>     param: Fix duplicate module prefixes
> 
> I assume.  Rusty's been on the schnapps again ;)

Indeed! :-) However it was fixed for next-20081128.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: mmotm 2008-11-29-01-53 uploaded

[Rusty Russell]

On Monday 01 December 2008 12:40:40 KAMEZAWA Hiroyuki wrote:
> On Sat, 29 Nov 2008 01:59:56 -0800
>
> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to
> >
> >    http://userweb.kernel.org/~akpm/mmotm/
> >
> > It contains the following patches against 2.6.28-rc6:
>
> Hi, in recent changes of linux-next.patch

Yep, it was mine.  Latest linux-next should have the fix (sfr berated me for
this bug earlier), which is below:

core_param: call these really, really early - fix

USB sets prefix to "", so there's no dot.  We should really be using
core_param for this.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 kernel/params.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/params.c b/kernel/params.c
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -634,7 +634,9 @@ static void __init param_sysfs_builtin(v
 			continue;
 
 		dot = strchr(kp->name, '.');
-		BUG_ON(!dot);
+		/* FIXME: USB code sets prefix to "".  Should use core_param */
+		if (!dot)
+			continue;
 		name_len = dot - kp->name + 1;
 		strlcpy(modname, kp->name, name_len);
 		kernel_add_sysfs_param(modname, kp, name_len);

Re: mmotm 2008-11-29-01-53 uploaded

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On Mon, 1 Dec 2008 15:07:33 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Yep, it was mine.  Latest linux-next should have the fix (sfr berated me for
> this bug earlier), which is below:

Clearly there should be more public be(r)atings :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]