[PATCH 1/1 #2] Char: n_tty, include module.h

[PATCH 1/1 #2] Char: n_tty, include module.h

[Jiri Slaby]

Hi,

this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.

--

Since we are using EXPORT_SYMBOL, we should include linux/module.h

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Rodolfo Giometti <giometti@linux.it>
---
 drivers/char/n_tty.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
index b441c09..8e6c591 100644
--- a/drivers/char/n_tty.c
+++ b/drivers/char/n_tty.c
@@ -41,6 +41,7 @@
 #include <linux/timer.h>
 #include <linux/ctype.h>
 #include <linux/mm.h>
+#include <linux/module.h>
 #include <linux/string.h>
 #include <linux/slab.h>
 #include <linux/poll.h>
-- 
1.6.0.4

Re: [PATCH 1/1 #2] Char: n_tty, include module.h

[Alan Cox]

On Wed,  3 Dec 2008 16:21:51 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:

> Hi,
> 
> this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.

NAK and NAK the patch needing it.

Once PPS is in this can be revisted by adding the almost identical N_PPS
ldisc into n_tty with a couple of different handlers (notably some of the
termios flags need to be handled differently)

Re: [PATCH 1/1 #2] Char: n_tty, include module.h

[Andrew Morton]

On Wed, 3 Dec 2008 15:35:37 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Wed,  3 Dec 2008 16:21:51 +0100
> Jiri Slaby <jirislaby@gmail.com> wrote:
> 
> > Hi,
> > 
> > this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
> 
> NAK and NAK the patch needing it.

Late :(

> Once PPS is in

PPS can't go in without this?

Perhaps I can drop pps-serial-clients-support.patch, dunno.

> this can be revisted by adding the almost identical N_PPS
> ldisc into n_tty with a couple of different handlers (notably some of the
> termios flags need to be handled differently)

Re: [PATCH 1/1 #2] Char: n_tty, include module.h

[Alan Cox]

> > NAK and NAK the patch needing it.
> 
> Late :(
> 
> > Once PPS is in
> 
> PPS can't go in without this?

PPS stands alone without the tty parts. Once the core PPS bits are
accepted (Ingo seems to be silent on that ?) I'll redo the N_PPS tty
bits.

Re: [PATCH 1/1 #2] Char: n_tty, include module.h

[Rodolfo Giometti]

On Wed, Dec 03, 2008 at 12:06:43PM -0800, Andrew Morton wrote:
> On Wed, 3 Dec 2008 15:35:37 +0000
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> 
> > On Wed,  3 Dec 2008 16:21:51 +0100
> > Jiri Slaby <jirislaby@gmail.com> wrote:
> > 
> > > Hi,
> > > 
> > > this is a ldisc-n_tty-export-all-n_tty-ldisc-methods.patch fix.
> > 
> > NAK and NAK the patch needing it.
> 
> Late :(
> 
> > Once PPS is in
> 
> PPS can't go in without this?

No, PPS works perfectly without that patch.

> Perhaps I can drop pps-serial-clients-support.patch, dunno.

I think you can drop the last fix.

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti