From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: hpa@kernel.org, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: cpuid.c fix style problems
Date: Fri, 2 Jan 2009 17:46:51 +0100 [thread overview]
Message-ID: <20090102164651.GA6759@elte.hu> (raw)
In-Reply-To: <1230721188.3738.2.camel@jaswinder.satnam>
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: cleanup, fix style problems
>
> Fixes style problems:
> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: trailing whitespace
> WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc
>
> total: 2 errors, 2 warnings
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/cpuid.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
applied to tip/x86/cleanups, thanks,
Ingo
prev parent reply other threads:[~2009-01-02 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 10:59 [PATCH] x86: cpuid.c fix style problems Jaswinder Singh Rajput
2008-12-31 13:01 ` Pekka Enberg
2009-01-02 18:58 ` Ingo Molnar
2009-01-02 16:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102164651.GA6759@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@kernel.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox