From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>,
Rusty Russell <rusty@rustcorp.com.au>,
Mike Travis <travis@sgi.com>
Cc: Jaswinder Singh Rajput <jaswinder@infradead.org>,
hpa@kernel.org, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: cpuid.c fix style problems
Date: Fri, 2 Jan 2009 19:58:29 +0100 [thread overview]
Message-ID: <20090102185829.GA14249@elte.hu> (raw)
In-Reply-To: <84144f020812310501w4c64de85r9125cfacccc5ae97@mail.gmail.com>
* Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On Wed, Dec 31, 2008 at 12:59 PM, Jaswinder Singh Rajput
> <jaswinder@infradead.org> wrote:
> > cpu = iminor(file->f_path.dentry->d_inode);
> > - if (cpu >= NR_CPUS || !cpu_online(cpu)) {
> > + if (cpu >= num_possible_cpus() || !cpu_online(cpu)) {
>
> How come you didn't convert the first part of the expression to use
> cpu_possible()?
i skipped this bit btw., as it got mooted by the cleanups in the cpumask
and cpus4096 trees.
Ingo
next prev parent reply other threads:[~2009-01-02 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 10:59 [PATCH] x86: cpuid.c fix style problems Jaswinder Singh Rajput
2008-12-31 13:01 ` Pekka Enberg
2009-01-02 18:58 ` Ingo Molnar [this message]
2009-01-02 16:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102185829.GA14249@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@kernel.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox