From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: nmi.c fix style problems
Date: Fri, 2 Jan 2009 18:24:39 +0100 [thread overview]
Message-ID: <20090102172439.GD6759@elte.hu> (raw)
In-Reply-To: <1230725102.3738.10.camel@jaswinder.satnam>
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: cleanup, fix style problems
>
> Fixes style problems:
> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
> WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>
>
> total: 0 errors, 2 warnings
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/nmi.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
> index 8bd1bf9..45a09cc 100644
> --- a/arch/x86/kernel/nmi.c
> +++ b/arch/x86/kernel/nmi.c
> @@ -26,11 +26,10 @@
> #include <linux/kernel_stat.h>
> #include <linux/kdebug.h>
> #include <linux/smp.h>
> +#include <linux/nmi.h>
>
> #include <asm/i8259.h>
> #include <asm/io_apic.h>
> -#include <asm/smp.h>
> -#include <asm/nmi.h>
> #include <asm/proto.h>
> #include <asm/timer.h>
does this build fine on UP + IOAPIC ? asm/smp.h has some side-effects that
brings in certain APIC definitions.
Ingo
next prev parent reply other threads:[~2009-01-02 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 12:05 [PATCH] x86: nmi.c fix style problems Jaswinder Singh Rajput
2009-01-02 17:24 ` Ingo Molnar [this message]
2009-01-02 17:53 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102172439.GD6759@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox