* [PATCH] x86: nmi.c fix style problems
@ 2008-12-31 12:05 Jaswinder Singh Rajput
2009-01-02 17:24 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2008-12-31 12:05 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, LKML
Impact: cleanup, fix style problems
Fixes style problems:
WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>
total: 0 errors, 2 warnings
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/nmi.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 8bd1bf9..45a09cc 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -26,11 +26,10 @@
#include <linux/kernel_stat.h>
#include <linux/kdebug.h>
#include <linux/smp.h>
+#include <linux/nmi.h>
#include <asm/i8259.h>
#include <asm/io_apic.h>
-#include <asm/smp.h>
-#include <asm/nmi.h>
#include <asm/proto.h>
#include <asm/timer.h>
--
1.5.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: nmi.c fix style problems
2008-12-31 12:05 [PATCH] x86: nmi.c fix style problems Jaswinder Singh Rajput
@ 2009-01-02 17:24 ` Ingo Molnar
2009-01-02 17:53 ` Jaswinder Singh Rajput
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-01-02 17:24 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: x86 maintainers, LKML
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: cleanup, fix style problems
>
> Fixes style problems:
> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
> WARNING: Use #include <linux/nmi.h> instead of <asm/nmi.h>
>
> total: 0 errors, 2 warnings
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/nmi.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
> index 8bd1bf9..45a09cc 100644
> --- a/arch/x86/kernel/nmi.c
> +++ b/arch/x86/kernel/nmi.c
> @@ -26,11 +26,10 @@
> #include <linux/kernel_stat.h>
> #include <linux/kdebug.h>
> #include <linux/smp.h>
> +#include <linux/nmi.h>
>
> #include <asm/i8259.h>
> #include <asm/io_apic.h>
> -#include <asm/smp.h>
> -#include <asm/nmi.h>
> #include <asm/proto.h>
> #include <asm/timer.h>
does this build fine on UP + IOAPIC ? asm/smp.h has some side-effects that
brings in certain APIC definitions.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-02 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-31 12:05 [PATCH] x86: nmi.c fix style problems Jaswinder Singh Rajput
2009-01-02 17:24 ` Ingo Molnar
2009-01-02 17:53 ` Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox