* pcf50663 MFD driver modular build failure
@ 2009-01-13 5:05 David Miller
2009-01-13 6:52 ` Balaji Rao
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2009-01-13 5:05 UTC (permalink / raw)
To: linux-kernel
Cc: sparclinux, balajirrao, andy, sameo, mingo, yinghai, akpm, sfr
This started happening with Linus's pull from today for
sparc64 allmodconfig:
ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
Sure we can export __set_irq_handler() and handle_level_irq() to
modules to fix this, but that looks like some hokey stuff for
a MFD driver to be doing :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pcf50663 MFD driver modular build failure
2009-01-13 5:05 pcf50663 MFD driver modular build failure David Miller
@ 2009-01-13 6:52 ` Balaji Rao
2009-01-14 1:29 ` Kyle McMartin
2009-01-14 21:47 ` Randy Dunlap
0 siblings, 2 replies; 5+ messages in thread
From: Balaji Rao @ 2009-01-13 6:52 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel, sparclinux, andy, sameo, mingo, yinghai, akpm, sfr
On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
>
> This started happening with Linus's pull from today for
> sparc64 allmodconfig:
>
> ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
>
> Sure we can export __set_irq_handler() and handle_level_irq() to
> modules to fix this, but that looks like some hokey stuff for
> a MFD driver to be doing :-)
Yes, right! It's really not necessary. I've sent a patch to remove it.
Thanks,
Balaji
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pcf50663 MFD driver modular build failure
2009-01-13 6:52 ` Balaji Rao
@ 2009-01-14 1:29 ` Kyle McMartin
2009-01-14 21:47 ` Randy Dunlap
1 sibling, 0 replies; 5+ messages in thread
From: Kyle McMartin @ 2009-01-14 1:29 UTC (permalink / raw)
To: Balaji Rao
Cc: David Miller, linux-kernel, sparclinux, andy, sameo, mingo,
yinghai, akpm, sfr
On Tue, Jan 13, 2009 at 12:22:02PM +0530, Balaji Rao wrote:
> On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> >
> > This started happening with Linus's pull from today for
> > sparc64 allmodconfig:
> >
> > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> >
> > Sure we can export __set_irq_handler() and handle_level_irq() to
> > modules to fix this, but that looks like some hokey stuff for
> > a MFD driver to be doing :-)
>
> Yes, right! It's really not necessary. I've sent a patch to remove it.
>
Thanks, I just hit this on a rawhide build as well...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pcf50663 MFD driver modular build failure
2009-01-13 6:52 ` Balaji Rao
2009-01-14 1:29 ` Kyle McMartin
@ 2009-01-14 21:47 ` Randy Dunlap
2009-01-15 5:03 ` Balaji Rao
1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2009-01-14 21:47 UTC (permalink / raw)
To: Balaji Rao
Cc: David Miller, linux-kernel, sparclinux, andy, sameo, mingo,
yinghai, akpm, sfr
On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:
> On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> >
> > This started happening with Linus's pull from today for
> > sparc64 allmodconfig:
> >
> > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> >
> > Sure we can export __set_irq_handler() and handle_level_irq() to
> > modules to fix this, but that looks like some hokey stuff for
> > a MFD driver to be doing :-)
>
> Yes, right! It's really not necessary. I've sent a patch to remove it.
Who did you send the patch to and where is it in the queue??
thanks,
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: pcf50663 MFD driver modular build failure
2009-01-14 21:47 ` Randy Dunlap
@ 2009-01-15 5:03 ` Balaji Rao
0 siblings, 0 replies; 5+ messages in thread
From: Balaji Rao @ 2009-01-15 5:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: David Miller, linux-kernel, sparclinux, andy, sameo, mingo,
yinghai, akpm, sfr
On Wed, Jan 14, 2009 at 01:47:12PM -0800, Randy Dunlap wrote:
> On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:
>
> > On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> > >
> > > This started happening with Linus's pull from today for
> > > sparc64 allmodconfig:
> > >
> > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> > >
> > > Sure we can export __set_irq_handler() and handle_level_irq() to
> > > modules to fix this, but that looks like some hokey stuff for
> > > a MFD driver to be doing :-)
> >
> > Yes, right! It's really not necessary. I've sent a patch to remove it.
>
> Who did you send the patch to and where is it in the queue??
Samuel has taken it into his linux-mfd tree and should be sending a pull
request real soon.
Thanks,
Balaji
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-15 5:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 5:05 pcf50663 MFD driver modular build failure David Miller
2009-01-13 6:52 ` Balaji Rao
2009-01-14 1:29 ` Kyle McMartin
2009-01-14 21:47 ` Randy Dunlap
2009-01-15 5:03 ` Balaji Rao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox