* [PATCH] mfd: Fix TWL4030 build on some ARM variants
@ 2009-01-30 18:42 Mark Brown
2009-01-30 19:46 ` David Brownell
2009-02-06 14:00 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2009-01-30 18:42 UTC (permalink / raw)
To: David Brownell, Samuel Ortiz; +Cc: linux-kernel, Mark Brown
Many ARM platforms do not provide a mach/cpu.h so rather than guarding
the use of that header with CONFIG_ARM guard it with the guards used
when testing for the OMAP variants in the body of the code.
Signed-off-by: Mark Brown <broonie@sirena.org.uk>
---
drivers/mfd/twl4030-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
index e7ab003..68826f1 100644
--- a/drivers/mfd/twl4030-core.c
+++ b/drivers/mfd/twl4030-core.c
@@ -38,7 +38,7 @@
#include <linux/i2c.h>
#include <linux/i2c/twl4030.h>
-#ifdef CONFIG_ARM
+#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
#include <mach/cpu.h>
#endif
--
1.5.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix TWL4030 build on some ARM variants
2009-01-30 18:42 [PATCH] mfd: Fix TWL4030 build on some ARM variants Mark Brown
@ 2009-01-30 19:46 ` David Brownell
2009-02-06 14:00 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: David Brownell @ 2009-01-30 19:46 UTC (permalink / raw)
To: Mark Brown; +Cc: Samuel Ortiz, linux-kernel
On Friday 30 January 2009, Mark Brown wrote:
> Many ARM platforms do not provide a mach/cpu.h so rather than guarding
> the use of that header with CONFIG_ARM guard it with the guards used
> when testing for the OMAP variants in the body of the code.
>
> Signed-off-by: Mark Brown <broonie@sirena.org.uk>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/mfd/twl4030-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index e7ab003..68826f1 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -38,7 +38,7 @@
> #include <linux/i2c.h>
> #include <linux/i2c/twl4030.h>
>
> -#ifdef CONFIG_ARM
> +#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
> #include <mach/cpu.h>
> #endif
>
> --
> 1.5.6.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix TWL4030 build on some ARM variants
2009-01-30 18:42 [PATCH] mfd: Fix TWL4030 build on some ARM variants Mark Brown
2009-01-30 19:46 ` David Brownell
@ 2009-02-06 14:00 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2009-02-06 14:00 UTC (permalink / raw)
To: Mark Brown; +Cc: David Brownell, linux-kernel
On Fri, Jan 30, 2009 at 06:42:17PM +0000, Mark Brown wrote:
> Many ARM platforms do not provide a mach/cpu.h so rather than guarding
> the use of that header with CONFIG_ARM guard it with the guards used
> when testing for the OMAP variants in the body of the code.
Applied, thanks a lot Mark.
Cheers,
Samuel.
> Signed-off-by: Mark Brown <broonie@sirena.org.uk>
> ---
> drivers/mfd/twl4030-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index e7ab003..68826f1 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -38,7 +38,7 @@
> #include <linux/i2c.h>
> #include <linux/i2c/twl4030.h>
>
> -#ifdef CONFIG_ARM
> +#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
> #include <mach/cpu.h>
> #endif
>
> --
> 1.5.6.3
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-06 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-30 18:42 [PATCH] mfd: Fix TWL4030 build on some ARM variants Mark Brown
2009-01-30 19:46 ` David Brownell
2009-02-06 14:00 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox