[PATCH 4/15] vfb: fix memory leaks in removal path

[PATCH 4/15] vfb: fix memory leaks in removal path

[Andres Salomon]

We were leaking the cmap memory.

Signed-off-by: Andres Salomon <dilinger@debian.org>
---
 drivers/video/vfb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
index 93fe08d..cc919ae 100644
--- a/drivers/video/vfb.c
+++ b/drivers/video/vfb.c
@@ -543,6 +543,7 @@ static int vfb_remove(struct platform_device *dev)
 	if (info) {
 		unregister_framebuffer(info);
 		rvfree(videomemory, videomemorysize);
+		fb_dealloc_cmap(&info->cmap);
 		framebuffer_release(info);
 	}
 	return 0;
-- 
1.5.6.5

Re: [Linux-fbdev-devel] [PATCH 4/15] vfb: fix memory leaks in removal path

[Krzysztof Helt]

On Sat, 7 Feb 2009 12:12:42 -0500
Andres Salomon <dilinger@queued.net> wrote:

> 
> We were leaking the cmap memory.
> 
> Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---

Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>


>  drivers/video/vfb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
> index 93fe08d..cc919ae 100644
> --- a/drivers/video/vfb.c
> +++ b/drivers/video/vfb.c
> @@ -543,6 +543,7 @@ static int vfb_remove(struct platform_device *dev)
>  	if (info) {
>  		unregister_framebuffer(info);
>  		rvfree(videomemory, videomemorysize);
> +		fb_dealloc_cmap(&info->cmap);
>  		framebuffer_release(info);
>  	}
>  	return 0;
> -- 
> 1.5.6.5
> 
> 
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code to
> build responsive, highly engaging applications that combine the power of local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
>