Re: viafb triggers BUG at mm/vmalloc.c:294 [kernel 2.6.28.3]

[Nick Piggin <nickpiggin@yahoo.com.au>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1510 bytes --]

On Sunday 08 February 2009 21:25:13 wixor wrote:> No, it didn't help really. Even with vmalloc=300M after a couple> modprobe/rmmods i got the same BUG. And I didn't manage to get> anything on display. Moreover, rmmod doesn't bring back the vga> console.
Thanks for reporting. I have a fix for this bug which is anoverflow issue reported by XFS guys... I've just been holdingoff merging it because they still seem to have a problemwith vmap that I'm trying to track down.
But if you could test this patch, it would be appreciated.
Thanks,Nick
--- mm/vmalloc.c |    6 ++++++ 1 file changed, 6 insertions(+)
Index: linux-2.6/mm/vmalloc.c===================================================================--- linux-2.6.orig/mm/vmalloc.c+++ linux-2.6/mm/vmalloc.c@@ -334,6 +334,9 @@ retry: 	addr = ALIGN(vstart, align);  	spin_lock(&vmap_area_lock);+	if (addr + size < addr)+		goto overflow;+ 	/* XXX: could have a last_hole cache */ 	n = vmap_area_root.rb_node; 	if (n) {@@ -365,6 +368,8 @@ retry:  		while (addr + size > first->va_start && addr + size <= vend) { 			addr = ALIGN(first->va_end + PAGE_SIZE, align);+			if (addr + size < addr)+				goto overflow;  			n = rb_next(&first->rb_node); 			if (n)@@ -375,6 +380,7 @@ retry: 	} found: 	if (addr + size > vend) {+overflow: 		spin_unlock(&vmap_area_lock); 		if (!purged) { 			purge_vmap_area_lazy();\0ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥