From: Alex Riesen <raa.lkml@gmail.com>, Alex Riesen <raa@blimp.localhost>
To: trivial@kernel.org
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Use a format string for linux_banner
Date: Sat, 28 Feb 2009 14:36:02 +0100 [thread overview]
Message-ID: <20090228133602.GA28239@blimp.localdomain> (raw)
In-Reply-To: <49A92783.1010709@s5r6.in-berlin.de>
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Stefan Richter, Sat, Feb 28, 2009 13:01:07 +0100:
> [+ application/octet-stream attachment, base64 encoded]
>
> Please send patches as inline text or at least as plaintext attachment
> in ascii encoding. linux/Documentation/email-clients.txt has help.
Couldn't. Had to either choose the corporate firewal and gmail, or the
Exchange-thing. Both will corrupt patches, unless send as attachment.
Decided not to expose the corporate mail address.
Anyway, resending from home now (back then couldn't send from home
either: was changing providers and had no usable link for a week.
Tell about coincidences...)
> > - printk(linux_banner);
> > + printk("%s", linux_banner);
>
> Better than that:
>
> - printk(KERN_NOTICE);
> - printk(linux_banner);
> + printk(KERN_NOTICE "%s", linux_banner);
>
Missed the line before. Poor blind me.
init/main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/init/main.c b/init/main.c
index 8442094..77fc028 100644
--- a/init/main.c
+++ b/init/main.c
@@ -553,8 +553,7 @@ asmlinkage void __init start_kernel(void)
tick_init();
boot_cpu_init();
page_address_init();
- printk(KERN_NOTICE);
- printk(linux_banner);
+ printk(KERN_NOTICE "%s", linux_banner);
setup_arch(&command_line);
mm_init_owner(&init_mm, &init_task);
setup_command_line(command_line);
--
1.6.2.rc2.31.gce6e3
next prev parent reply other threads:[~2009-02-28 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 9:04 [PATCH] Use a format string for linux_banner Alex Riesen
2009-02-28 12:01 ` Stefan Richter
2009-02-28 13:36 ` Alex Riesen, Alex Riesen [this message]
2009-02-28 17:27 ` Linus Torvalds
2009-05-24 13:30 ` [PATCH] Use a format " Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090228133602.GA28239@blimp.localdomain \
--to=raa.lkml@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raa@blimp.localhost \
--cc=stefanr@s5r6.in-berlin.de \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox