public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: trivial@kernel.org, Stefan Richter <stefanr@s5r6.in-berlin.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] Use a format for linux_banner
Date: Sun, 24 May 2009 15:30:48 +0200	[thread overview]
Message-ID: <20090524133047.GA24869@blimp.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0902280924150.3111@localhost.localdomain>

There is no format specifiers left in the linux_banner, and gcc-4.3
complains seeing the printk.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

Linus Torvalds, Sat, Feb 28, 2009 18:27:07 +0100:
> What people _can_ do is to send it both as a crazy attachment _and_ as 
> plaintext. If they plaintext gets corrupted, the attachment still works, 
> and the plaintext is at least somethign I can see and thus in my mail 
> reader decide whether it's worth my time to save the attachment and look 
> at it outside the mail reader.

Resent properly. Sorry, took me a while.

 init/main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/init/main.c b/init/main.c
index 3bbf93b..d721dad 100644
--- a/init/main.c
+++ b/init/main.c
@@ -566,8 +566,7 @@ asmlinkage void __init start_kernel(void)
 	tick_init();
 	boot_cpu_init();
 	page_address_init();
-	printk(KERN_NOTICE);
-	printk(linux_banner);
+	printk(KERN_NOTICE "%s", linux_banner);
 	setup_arch(&command_line);
 	mm_init_owner(&init_mm, &init_task);
 	setup_command_line(command_line);
-- 
1.6.3.1.171.ge2f07


      reply	other threads:[~2009-05-24 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  9:04 [PATCH] Use a format string for linux_banner Alex Riesen
2009-02-28 12:01 ` Stefan Richter
2009-02-28 13:36   ` Alex Riesen, Alex Riesen
2009-02-28 17:27     ` Linus Torvalds
2009-05-24 13:30       ` Alex Riesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090524133047.GA24869@blimp.localdomain \
    --to=raa.lkml@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox