Re: fs: move bdev code out of buffer.c

Re: fs: move bdev code out of buffer.c

[Andrew Morton]

On Sat, 28 Mar 2009 00:59:57 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:

> Gitweb:     http://git.kernel.org/linus/585d3bc06f4ca57f975a5a1f698f65a45ea66225
> Commit:     585d3bc06f4ca57f975a5a1f698f65a45ea66225
> Parent:     3ba13d179e8c24c68eac32b93593a6b10fcd1572
> Author:     Nick Piggin <npiggin@suse.de>
> AuthorDate: Wed Feb 25 10:44:19 2009 +0100
> Committer:  Al Viro <viro@zeniv.linux.org.uk>
> CommitDate: Fri Mar 27 14:44:03 2009 -0400
> 
>     fs: move bdev code out of buffer.c
>     
>     Move some block device related code out from buffer.c and put it in
>     block_dev.c. I'm trying to move non-buffer_head code out of buffer.c
>     
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

This patch moved the CONFIG_BLOCK=y declaration of freeze_bdev() out of
buffer_head.h and into fs.h.  But it left the CONFIG_BLOCK=n definition
of freeze_bdev() in buffer_head.h.

I'd have noticed this earlier had this patch been in linux-next.  But
despite having been apparently written over a month ago, it was never
(afaict) in linux-next.

This patch is missing Nick's Signed-off-by:.

Re: fs: move bdev code out of buffer.c

[Al Viro]

On Mon, Mar 30, 2009 at 11:55:24AM -0700, Andrew Morton wrote:

> This patch moved the CONFIG_BLOCK=y declaration of freeze_bdev() out of
> buffer_head.h and into fs.h.  But it left the CONFIG_BLOCK=n definition
> of freeze_bdev() in buffer_head.h.

Actually, there's more.
	a) fsync_bdev() export is left behind in buffer.c
	b) sync_blockdev/invalidate_bdev are like freeze_bdev/thaw_bdev -
non-block stubs need to be moved.

Fixed and pushed into for-next

Re: fs: move bdev code out of buffer.c

[Nick Piggin]

On Wednesday 01 April 2009 22:10:03 Al Viro wrote:
> On Mon, Mar 30, 2009 at 11:55:24AM -0700, Andrew Morton wrote:
> > This patch moved the CONFIG_BLOCK=y declaration of freeze_bdev() out of
> > buffer_head.h and into fs.h.  But it left the CONFIG_BLOCK=n definition
> > of freeze_bdev() in buffer_head.h.
>
> Actually, there's more.
> 	a) fsync_bdev() export is left behind in buffer.c
> 	b) sync_blockdev/invalidate_bdev are like freeze_bdev/thaw_bdev -
> non-block stubs need to be moved.
>
> Fixed and pushed into for-next

Sorry about that, thanks. I always forget to test CONFIG_BLOCK=n :(