From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org
Subject: Re: USB: serial: add symbol serial driver
Date: Mon, 6 Apr 2009 10:14:01 +0100 [thread overview]
Message-ID: <20090406101401.4be69c01@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090406053753.GA12019@kroah.com>
> > The above is bogus cargo cult programming copied from old drivers and
> > should be removed.
>
> It's all over the usb-serial drivers, should I just remove it from all
> of them?
I think so yes. USB folks used it to avoid overrunning the old flip
buffer system and with proper buffering that isn't needed. Now its only
relevance is if you need very low latency responses which is normally an
application layer choice.
Alan
prev parent reply other threads:[~2009-04-06 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903261929.n2QJTS5L009700@hera.kernel.org>
2009-03-26 19:42 ` USB: serial: add symbol serial driver Alan Cox
2009-04-06 5:37 ` Greg KH
2009-04-06 9:14 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406101401.4be69c01@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox