From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org
Subject: Re: USB: serial: add symbol serial driver
Date: Sun, 5 Apr 2009 22:37:53 -0700 [thread overview]
Message-ID: <20090406053753.GA12019@kroah.com> (raw)
In-Reply-To: <20090326194228.52087a47@lxorguk.ukuu.org.uk>
On Thu, Mar 26, 2009 at 07:42:28PM +0000, Alan Cox wrote:
> On Thu, 26 Mar 2009 19:29:28 GMT
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
>
> Thank you for not running this past the tty layer maintainer.
Sorry about that.
> > + /*
> > + * Force low_latency on so that our tty_push actually forces the data
> > + * through, otherwise it is scheduled, and with high data rates (like
> > + * with OHCI) data can get lost.
> > + */
> > + if (tty)
> > + tty->low_latency = 1;
>
> The above is bogus cargo cult programming copied from old drivers and
> should be removed.
It's all over the usb-serial drivers, should I just remove it from all
of them?
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-06 5:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903261929.n2QJTS5L009700@hera.kernel.org>
2009-03-26 19:42 ` USB: serial: add symbol serial driver Alan Cox
2009-04-06 5:37 ` Greg KH [this message]
2009-04-06 9:14 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406053753.GA12019@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox