* Re: USB: serial: add symbol serial driver [not found] <200903261929.n2QJTS5L009700@hera.kernel.org> @ 2009-03-26 19:42 ` Alan Cox 2009-04-06 5:37 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Alan Cox @ 2009-03-26 19:42 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: torvalds, greg On Thu, 26 Mar 2009 19:29:28 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote: Thank you for not running this past the tty layer maintainer. > + /* > + * Force low_latency on so that our tty_push actually forces the data > + * through, otherwise it is scheduled, and with high data rates (like > + * with OHCI) data can get lost. > + */ > + if (tty) > + tty->low_latency = 1; The above is bogus cargo cult programming copied from old drivers and should be removed. Otherwise looks fine ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: USB: serial: add symbol serial driver 2009-03-26 19:42 ` USB: serial: add symbol serial driver Alan Cox @ 2009-04-06 5:37 ` Greg KH 2009-04-06 9:14 ` Alan Cox 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2009-04-06 5:37 UTC (permalink / raw) To: Alan Cox; +Cc: Linux Kernel Mailing List, torvalds On Thu, Mar 26, 2009 at 07:42:28PM +0000, Alan Cox wrote: > On Thu, 26 Mar 2009 19:29:28 GMT > Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote: > > Thank you for not running this past the tty layer maintainer. Sorry about that. > > + /* > > + * Force low_latency on so that our tty_push actually forces the data > > + * through, otherwise it is scheduled, and with high data rates (like > > + * with OHCI) data can get lost. > > + */ > > + if (tty) > > + tty->low_latency = 1; > > The above is bogus cargo cult programming copied from old drivers and > should be removed. It's all over the usb-serial drivers, should I just remove it from all of them? thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: USB: serial: add symbol serial driver 2009-04-06 5:37 ` Greg KH @ 2009-04-06 9:14 ` Alan Cox 0 siblings, 0 replies; 3+ messages in thread From: Alan Cox @ 2009-04-06 9:14 UTC (permalink / raw) To: Greg KH; +Cc: Linux Kernel Mailing List, torvalds > > The above is bogus cargo cult programming copied from old drivers and > > should be removed. > > It's all over the usb-serial drivers, should I just remove it from all > of them? I think so yes. USB folks used it to avoid overrunning the old flip buffer system and with proper buffering that isn't needed. Now its only relevance is if you need very low latency responses which is normally an application layer choice. Alan ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-06 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200903261929.n2QJTS5L009700@hera.kernel.org>
2009-03-26 19:42 ` USB: serial: add symbol serial driver Alan Cox
2009-04-06 5:37 ` Greg KH
2009-04-06 9:14 ` Alan Cox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox