* [PATCH] regulator/virtual: fix strings compare predicates
@ 2009-04-26 8:49 Mike Rapoport
2009-04-26 9:47 ` Mark Brown
2009-04-27 11:40 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Mike Rapoport @ 2009-04-26 8:49 UTC (permalink / raw)
To: broonie; +Cc: lrg, linux-kernel, Mike Rapoport
Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
drivers/regulator/virtual.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
index 3d08348..71403fa 100644
--- a/drivers/regulator/virtual.c
+++ b/drivers/regulator/virtual.c
@@ -230,13 +230,13 @@ static ssize_t set_mode(struct device *dev, struct device_attribute *attr,
* sysfs_streq() doesn't need the \n's, but we add them so the strings
* will be shared with show_mode(), above.
*/
- if (sysfs_streq(buf, "fast\n") == 0)
+ if (sysfs_streq(buf, "fast\n"))
mode = REGULATOR_MODE_FAST;
- else if (sysfs_streq(buf, "normal\n") == 0)
+ else if (sysfs_streq(buf, "normal\n"))
mode = REGULATOR_MODE_NORMAL;
- else if (sysfs_streq(buf, "idle\n") == 0)
+ else if (sysfs_streq(buf, "idle\n"))
mode = REGULATOR_MODE_IDLE;
- else if (sysfs_streq(buf, "standby\n") == 0)
+ else if (sysfs_streq(buf, "standby\n"))
mode = REGULATOR_MODE_STANDBY;
else {
dev_err(dev, "Configuring invalid mode\n");
--
1.5.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator/virtual: fix strings compare predicates
2009-04-26 8:49 [PATCH] regulator/virtual: fix strings compare predicates Mike Rapoport
@ 2009-04-26 9:47 ` Mark Brown
2009-04-27 11:40 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2009-04-26 9:47 UTC (permalink / raw)
To: Mike Rapoport; +Cc: lrg, linux-kernel
On Sun, Apr 26, 2009 at 11:49:30AM +0300, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
Good catch, thanks.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator/virtual: fix strings compare predicates
2009-04-26 8:49 [PATCH] regulator/virtual: fix strings compare predicates Mike Rapoport
2009-04-26 9:47 ` Mark Brown
@ 2009-04-27 11:40 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2009-04-27 11:40 UTC (permalink / raw)
To: Mike Rapoport; +Cc: broonie, linux-kernel
On Sun, 2009-04-26 at 11:49 +0300, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
> drivers/regulator/virtual.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-27 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-26 8:49 [PATCH] regulator/virtual: fix strings compare predicates Mike Rapoport
2009-04-26 9:47 ` Mark Brown
2009-04-27 11:40 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox