From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
the arch/x86 maintainers <x86@kernel.org>,
Matthew Wilcox <willy@linux.intel.com>,
Joerg Roedel <joerg.roedel@amd.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Alex Nixon <alex.nixon@citrix.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions
Date: Thu, 14 May 2009 12:15:13 -0700 [thread overview]
Message-ID: <20090514121513.198ada4e@jbarnes-g45> (raw)
In-Reply-To: <4A0C66DB.9020707@goop.org>
On Thu, 14 May 2009 11:45:47 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Jesse Barnes wrote:
> > Anyway it's not a big deal, this code is already ugly (a 0 define
> > for all arches? why?) so you shouldn't have to spend too much time
> > cleaning it up.
> >
>
> OK, how's this as a delta (I can fold it into the previous patch if
> you're OK with it):
>
> Subject: [PATCH] pci: add HAVE_ARCH_PCIBIOS_SCAN_ALL_FNS
>
> Jesse objected to the "#undef pcibios_scan_all_fns"'s ugliness,
> so replace it with the more common HAVE_ARCH_ idiom.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
That's slightly better. It looks like we should just get rid of
pcibios_scan_all_fns altogether, but this is fine for now.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-05-14 19:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 21:48 [GIT PULL] xen dom0 PCI access Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 01/10] xen: Don't disable the I/O space Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 02/10] xen: Allow unprivileged Xen domains to create iomap pages Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 03/10] Xen: Rename the balloon lock Jeremy Fitzhardinge
2009-05-13 3:17 ` [Xen-devel] " Isaku Yamahata
2009-05-12 21:48 ` [PATCH 04/10] xen: Add xen_create_contiguous_region Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 05/10] x86/PCI: Clean up pci_cache_line_size Jeremy Fitzhardinge
2009-05-13 16:45 ` Jesse Barnes
2009-05-12 21:48 ` [PATCH 06/10] x86/PCI: Enable scanning of all pci functions Jeremy Fitzhardinge
2009-05-13 16:55 ` Jesse Barnes
2009-05-13 17:08 ` Jeremy Fitzhardinge
2009-05-13 17:23 ` Jesse Barnes
2009-05-13 20:32 ` Jeremy Fitzhardinge
2009-05-14 18:45 ` Jeremy Fitzhardinge
2009-05-14 19:15 ` Jesse Barnes [this message]
2009-05-15 0:07 ` Alex Chiang
2009-05-12 21:48 ` [PATCH 07/10] Xen/x86/PCI: Add support for the Xen PCI subsystem Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 08/10] x86/pci: make sure _PAGE_IOMAP it set on pci mappings Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 09/10] xen/pci: clean up Kconfig a bit Jeremy Fitzhardinge
2009-05-12 21:48 ` [PATCH 10/10] xen: define BIOVEC_PHYS_MERGEABLE() Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2009-05-27 7:24 [GIT PULL REPOST] xen/dom0/pci - Xen dom0 PCI access Jeremy Fitzhardinge
2009-05-27 7:24 ` [PATCH 06/10] x86/PCI: Enable scanning of all pci functions Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090514121513.198ada4e@jbarnes-g45 \
--to=jbarnes@virtuousgeek.org \
--cc=alex.nixon@citrix.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox