The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hwmon: (lm78) add missing __devexit_p()
Date: Sat, 16 May 2009 12:02:29 +0200	[thread overview]
Message-ID: <20090516120229.4bc622b7@hyperion.delvare> (raw)
In-Reply-To: <1242413423-26654-1-git-send-email-vapier@gentoo.org>

Hi Mike,

On Fri, 15 May 2009 14:50:23 -0400, Mike Frysinger wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Jean Delvare <khali@linux-fr.org>
> ---
>  drivers/hwmon/lm78.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
> index b5e3b28..a1787fd 100644
> --- a/drivers/hwmon/lm78.c
> +++ b/drivers/hwmon/lm78.c
> @@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
>  		.name	= "lm78",
>  	},
>  	.probe		= lm78_isa_probe,
> -	.remove		= lm78_isa_remove,
> +	.remove		= __devexit_p(lm78_isa_remove),
>  };
>  
>  

Good catch. Applied, thanks!

-- 
Jean Delvare

      reply	other threads:[~2009-05-16 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 18:50 [PATCH] hwmon: (lm78) add missing __devexit_p() Mike Frysinger
2009-05-16 10:02 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090516120229.4bc622b7@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox