* [PATCH] hwmon: (lm78) add missing __devexit_p()
@ 2009-05-15 18:50 Mike Frysinger
2009-05-16 10:02 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2009-05-15 18:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Jean Delvare
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: Jean Delvare <khali@linux-fr.org>
---
drivers/hwmon/lm78.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
index b5e3b28..a1787fd 100644
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
.name = "lm78",
},
.probe = lm78_isa_probe,
- .remove = lm78_isa_remove,
+ .remove = __devexit_p(lm78_isa_remove),
};
--
1.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (lm78) add missing __devexit_p()
2009-05-15 18:50 [PATCH] hwmon: (lm78) add missing __devexit_p() Mike Frysinger
@ 2009-05-16 10:02 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2009-05-16 10:02 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, Andrew Morton
Hi Mike,
On Fri, 15 May 2009 14:50:23 -0400, Mike Frysinger wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/lm78.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
> index b5e3b28..a1787fd 100644
> --- a/drivers/hwmon/lm78.c
> +++ b/drivers/hwmon/lm78.c
> @@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
> .name = "lm78",
> },
> .probe = lm78_isa_probe,
> - .remove = lm78_isa_remove,
> + .remove = __devexit_p(lm78_isa_remove),
> };
>
>
Good catch. Applied, thanks!
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-16 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-15 18:50 [PATCH] hwmon: (lm78) add missing __devexit_p() Mike Frysinger
2009-05-16 10:02 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox