public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/X] ptrace: mv task_struct->ptrace ptrace_task->pt_flags, kill ptrace_link()
Date: Mon, 25 May 2009 05:33:03 +0200	[thread overview]
Message-ID: <20090525033303.GB20687@elte.hu> (raw)
In-Reply-To: <20090525000008.GA2228@redhat.com>


* Oleg Nesterov <oleg@redhat.com> wrote:

>  struct ptrace_task {
> +	unsigned long	pt_flags;
>  };

> -	return task->ptrace;
> +	return unlikely(task->ptrace_task) ?
> +		task->ptrace_task->pt_flags : 0;

Please no pt_ prefixes. It is abundantly clear from the 
'->ptrace_ctx' portion already that it's about ptrace - the rest 
should be a straightforward minimalistic naming - i.e. 
->ptrace_ctx->flags.

Also, is the conditional necessary? We should not be calling ptrace 
methods on tasks with no ptrace context.

Thanks,

	Ingo

  reply	other threads:[~2009-05-25  3:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25  0:00 [RFC PATCH 5/X] ptrace: mv task_struct->ptrace ptrace_task->pt_flags, kill ptrace_link() Oleg Nesterov
2009-05-25  3:33 ` Ingo Molnar [this message]
2009-05-25 16:03   ` Oleg Nesterov
2009-05-26 20:55 ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090525033303.GB20687@elte.hu \
    --to=mingo@elte.hu \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox