public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/X] ptrace: mv task_struct->ptrace ptrace_task->pt_flags, kill ptrace_link()
Date: Tue, 26 May 2009 13:55:37 -0700 (PDT)	[thread overview]
Message-ID: <20090526205537.C5101FC2BD@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Monday, 25 May 2009 02:00:08 +0200 <20090525000008.GA2228@redhat.com>

>  static inline int task_ptrace(struct task_struct *task)
>  {
> -	return task->ptrace;
> +	return unlikely(task->ptrace_task) ?
> +		task->ptrace_task->pt_flags : 0;

This merits a short comment reminding the reader that once ->ptrace_task is
allocated, it is never freed until @task is freed, so this access is always
safe.


Thanks,
Roland

      parent reply	other threads:[~2009-05-26 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-25  0:00 [RFC PATCH 5/X] ptrace: mv task_struct->ptrace ptrace_task->pt_flags, kill ptrace_link() Oleg Nesterov
2009-05-25  3:33 ` Ingo Molnar
2009-05-25 16:03   ` Oleg Nesterov
2009-05-26 20:55 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526205537.C5101FC2BD@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox